I found some problems with theming in the module:

  • No declaration of the theme_node_editors and theme_node_viewers inside hook_theme()
  • Theming functions should use the module's namespace, e.g. theme_modulename_xyz()
  • Theming functions should return HTML only (these returned an array element for $node->content)

This patch aims to fix this.

CommentFileSizeAuthor
coherent_access_theming.patch3.19 KBjanusman

Comments

MGN’s picture

MGN commented

The patch looks good.

Is there a purpose for the space after the spans?

Other than that, I think this is a real improvement and helps to bring the module in line with expectations.
I've applied the patch and tried it out and haven't found any problems.

janusman’s picture

janusman commented

No purpose in space after spans other than... uhm... spacing =)

janusman’s picture

janusman commented
Title: Fix theming funcions » Fix theming functions

Fixed typo in issue title.