Closed (fixed)
Project:
Project
Version:
6.x-1.x-dev
Component:
Releases
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
21 Aug 2010 at 23:44 UTC
Updated:
3 Jan 2014 at 02:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dwwTotally untested, but here's a first stab at this.
Comment #2
dwwSlightly more tested. Still not able to save the values with drush yet, but we're getting closer.
Comment #3
dwwThis fixes the query so that we correctly record values with 0s for weeks without any releases. Not sure if we want the big nasty query in here now to get all the 0s, or if it's better to do the simpler query from the previous patches and handle the 0s via PHP.
Now also with a sort of functional default view for the corresponding sparkline, although I think we're getting nailed by #905902: Option for missing/empty values since we've now got a bunch of 0s in here. ;)
I'm also wondering if this should be a multi-valued metric, split by API compatibility terms (e.g. 6.x vs. 7.x) and a stacked bar-chart sparkline.
Comment #4
hunmonk commentedsince new API compatibility terms are inevitable, i would advocate, if we want them split, for each to be a separate individual metric. this would be much easier to manage schema-wise.
Comment #5
dww- Renamed the metric to "new releases" to make it more obvious this is the release "delta", not a total.
- Fixed the query to restrict to project nodes (given all the LEFT JOINing now, we need this).
- Fixed up some code comments.
Comment #6
hunmonk commented#914182: method plugins should pass everything a metric needs in the sample objects has landed, so this metric now needs to be updated.
Comment #7
hunmonk commentedupdate the patch in #6 for the sampler API changes -- seems to work perfectly in light testing.
Comment #8
hunmonk commentedlatest patch, adds batch support.
Comment #9
hunmonk commentedmerged in commit http://drupalcode.org/project/project.git/commit/66ea5d6