Closed (fixed)
Project:
Media Development Profile
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Aug 2010 at 22:53 UTC
Updated:
6 Oct 2011 at 02:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
brunodboThis one also gets media_flickr & media_youtube (Plupload doesn't have a 7 release yet).
Comment #2
webchickMarking needs review.
Comment #3
brunodboSome updates:
- Plupload has a D7 version, so it's included in the make file
- CVS checkout of HEAD version of Media (instead of dev snapshot)
- Some common sense changes
(Note: there is currently a problem while installing the media dev profile: #946322: Error while installing on D7 beta2)
Comment #4
clemens.tolboomI would like to add the following. I'm upgrading from a D6 provider.
Comment #5
webchickI don't think that makes sense. Media is a new module.
Comment #6
webchickWow, I finally got the chance to test this tonight. FRICKING AWESOME! This is sooo much easier than the current method, which I have yet to actually get to work! :D
I would love for this to be committed, but unfortunately atm it needs work because README.txt needs a patch to include your helpful instructions. ;)
Additionally, I think that at least media_dev and media_youtube, but perhaps even all of these dependent projects should be checking out from their 7.x-X.x-dev equivalents. At least the README.txt seems to allude to this, since it recommends checking out either HEAD or DRUPAL-7--1 branches of each project.
Comment #7
webchickSuggested text for README.txt. I'd make a patch, but it's not checked out via CVS in the .make file so I can't.
Comment #8
webchickAnd finally, according to the latest commit at http://drupalcode.org/viewvc/drupal/contributions/profiles/media_dev/med..., entity is no longer a dependency, so that should be removed.
Comment #9
brunodbo@clemens.tolboom: This make file is intended to make setup of the media_dev profile easier, so I don't really see the point of adding projects other than those listed on http://drupal.org/project/media?
Comment #10
brunodboAttaching an updated version of this make file:
- Updated all projects to their 7.x-x-dev version where possible
- Removed entity
- Included all optional modules as listed on http://drupal.org/project/media
- Updated CKEditor version to 3.5
Comment #11
brunodboSmall change to download core 7.x-dev.
Shouldn't we remove the core project though, as mentioned in http://drupalcode.org/viewvc/drupal/contributions/modules/drush_make/EXA...
Comment #12
brunodbo@webchick (#07): README.txt instructions looking good, patch at http://drupal.org/node/1030656.
(The make file now downloads README.txt after changing the download method from CVS to regular Drush make style.)
Comment #13
brunodboComment #14
clemens.tolboom@webchick comment #5 : I still like to have those modules added :)
There is a huge amount of media providing modules to get converted to D7 so it certainly would help
Comment #15
marcvangendThe make file from #11 didn't work for me. Copy-paste from the command line:
I'm not sure if this is the optimal solution, but the make file attached here did work for me. I only removed the line
projects[drupal][version] = "7.x-dev"and addedprojects[drupal][type] = "core".Comment #16
ethanw commentedUpdated following the instructions on Drush Make theory for happy profile development: removed the core project from the profile makefile (to be added in separate stub makefile). Also added the coder module, will post a separate patch to profile to enable it. Tested with profile and appears to work end-to-end.
Comment #17
ethanw commentedRemoved core project properly this time: by deleting lines and not just commenting out.
Comment #18
eojthebraveThis is looking awesome. Thanks for working on it. There are two little tweaks that I think should be made. 1.) Can we wrap the comments at 80 characters. 2.) Should be be grabbing the 3.5.2 version of CKEditor instead of the 3.5 version?
Comment #19
brunodboHere are some more changes:
- Changed media_gallery & media_browser_plus to their dev versions, so we'll use the dev versions of all downloaded contrib modules.
- Wrapped comments to 80 chars.
- Changed CKEditor version to 3.5.2, since this is the lastest stablle release of CKEditor.
Comment #20
brunodboAnd here's a patch that adds the make file to media_dev.profile.
This is also my first ever git patch, so this might be horribly wrong ;)
Comment #21
Ryanbach commentedI am trying this, but I get this error ( I did a drush dl media_dev first) then ran this command:
Comment #22
brunodboAre you sure you're using the correct path to the make file?
That said, this make file won't work (I think) before http://drupal.org/node/1087304 (and this one) gets in. We're using two make files now: one to get core and media_dev (the profile), another -this- one to get all the contrib, libraries, ... So since we're not specifying the core project in this make file anymore, this make file won't work by itself.
See http://drupal.org/node/1006620 for more info.
Comment #23
Ryanbach commentedI copied it over, now I get:
Edit: I get this with #19
Comment #24
Ryanbach commentedNevermind...
Comment #25
brunodboNote: we should also add the Plupload library.
Comment #26
brunodboAnd the MediaElement library.
Comment #27
webchickHm. Unfortunately #16+ seem to have made this profile uninstallable. :(
I'm definitely no Drush Make expert, but I really don't understand the recommendations at http://drupal.org/node/1006620. It seems like this effectively makes it impossible to test adjustments to make files before they're committed to the project.
So here I am going back to the old approach, which is probably wrong, but at least lets you do something useful. :)
Changes:
- re-added the projects[drupal][type] = "core" and projects[] = media_dev lines.
- mediaelement doesn't expose a 1.x-dev release, so changed to 1.1 and left a comment.
- ctools is now a dependency. added it.
Comment #28
brunodboDuring one of the Media sprints in Chicago, we opted for the 'stub make file' approach (http://drupal.org/node/1006620), but never got around to finish it properly, let alone get it committed so it would work.
Going back to the first approach for now seems like the right thing to do here, since it does make testing & set-up a lot more convenient :) The 'stub make file' approach seems to be especially handy when you're working with several profiles, while here we just want to make the set-up of the media_dev profile easier. If we want to, we can split up make files later.
Some more changes:
- Added plupload & mediaelement libraries.
- Added libraries.module (required by mediaelement)
I'll ask one of the Media people to review this as well.
Comment #29
JacobSingh commentedThe styles module is not required anymore. Otherwise it looks very good.
Jacob
Comment #30
aaron commentedlooks really good. two notes, that may or may not affect things:
- styles is optional now
- we just created a 7.x-2.x branch, which will require the File Entity module.
Comment #31
brunodbo- Moved Styles from required to Optional
- I'll update media's branch version & add file_entity once they have releases.
Comment #32
brunodboDone (see #31).
Comment #33
JacobSingh commentedI don't know the drush make format well, but is it possible to DL but not enable mods? mediaelement and styles might want to be in that category. Also, not sure we need devel and coder there. I think I originally put devel there to make my life easier so I wouldn't have to remember to enable it :) But I guess it's probably not a best practice.
-J
Comment #34
brunodboThe make file only downloads stuff, it's the profile's info file (I think) that enables modules (or not). So yep, it's totally possible to only download modules, but not enable them (ie. not list them as a dependency) in the info file. I can check this out during the week, there are some other things in the info file that need updating (description ..).
During the media sprint in Chicago, it made sense to us to include devel & coder, since the profile is meant for developers. Perhaps we can also only just download them (or only devel), and leave them disabled in the profile's installation.
Comment #35
kreynen commentedThere is another dev environment for testing Derivative engines, but it would be great to include more of the provider modules and media_feeds.
Comment #36
brunodboCommitted and pushed!
Notes:
- I added a bootstrap make file (based on http://drupal.org/project/drupalorg_testing), since the one-make-file-approach was generating weird recursive drush make errors.
- To use the make file, run
drush make http://is.gd/8EKNFT --prepare-install media_devPlease file a new issue to suggest new modules etc. Marking this one as fixed.
Comment #37
maryedith commentedI have tried to download the Media Development profile using the most recent media_dev.make file from this page. Continually get errors on plupload and mediaelement:
Can you help? thanks, Mary Edith
http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.6.1/ckeditor....
Unable to download plupload from [error]
https://github.com/downloads/moxiecode/plupload/plupload_1_4_3_2.zip.
Unable to download mediaelement from [error]
https://github.com/kaichen/mediaelement/zipball/2.1.6.
Comment #38
maryedith commentedFollowing on from my last comment, I also tried the command: http://is.gd/8EKNFT --prepare-install media_dev ; Same result. thanks.
Comment #39
brunodboHmm, I'm not getting these errors myself. Anyone else having problems with Plupload/MediaElement?
You could try running
drush make http://is.gd/8EKNFT --prepare-install --force-complete media_devto finish the build despite the errors, and then manually drop Plupload and MediaElement in the /sites/all/libraries folder.
Comment #40
bensnyder commentedI bit dissapointed I can't get it to work either :(