Closed (fixed)
Project:
Album Photos
Version:
7.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 Aug 2010 at 14:40 UTC
Updated:
8 Feb 2013 at 21:40 UTC
Mozilla Firebug reports "uncaught exception: Syntax error, unrecognized expression: [@class="image-quote-link"]" when installing this module. I have marked this issue major because it both breaks Quick Tabs and Vertical Tabs.
Comments
Comment #1
avic commentedTo be more precise: The error is shown when displaying any node while the module is activated (not on admin pages).
Comment #2
chrixix commentedI had the same error : maybe it's a jquery version issue. I turned off jquery update module and no more error. Jquery 1.3.x doesn't support the '@' statement ( [@class="image-quote-link"] ).
Comment #3
killua99 commentedHi,
I need to use de last jQuery or at least since 1.3 > so I'm realy thinking about hack the module to fix this issue for me. But Actualy I'll try to hack in the better way to make a patch that the two version can use this module.
I add this line on photos.js
Comment #4
nathaniel commentedIf you are using jQuery update go through photos.js and change all instances of [@class="class-name"] to .class-name
example:
I can post a patch later, if anyone needs one.
Comment #5
plato1123 commentedCan we have a new version of the photos module that includes the update photos.js? I think I can handle the patching of this file but I bet a lot of newbs heads are going to explode over this one
edit: Note this causes some nasty problems with the newest ckeditor as documented here: http://drupal.org/node/1565884
Comment #6
plato1123 commentedhere's the lines I had to change: 74, 80, 93, 96, 99 in photos.js
74:
$('#photos_share_ul li select[@class="photos_share_select_val"]').change(function(){to
$('#photos_share_ul li select.photos_share_select_val').change(function(){80
$('#photos_share_ul li select[@class="photos_share_select_val"]').each(function(){to
$('#photos_share_ul li select.photos_share_select_val').each(function(){93
$('input[@class="image-quote-link"], .photos_share_textarea').click(function(){to
$('input.image-quote-link, .photos_share_textarea').click(function(){96
$('input[@class="photos-p"]').change(function() {to
$('input.photos-p').change(function() {99
$("input[@class='photos-p'],input[@class='photos-pp']").each(function() {to
$('input.photos-p,input.photos-pp').each(function() {and... ... it worked?!?! holy crap
Comment #7
plato1123 commentedHere's the entire photos.js file (part of the photos module) that has been updated. We should release a newer version of the photos module with this updated photos.js -- in the mean time here's the updated photos.js in its entirety (thanks to Nathaniel for the help):
Comment #8
nathaniel commentedFixed in the 7.x version.