Upgraded to 5.0

please provide a real patch: http://drupal.org/patch

OK, the new attached file now includes the .patch file.

I get 2 empty tabs in the search page:
(empty) | Content | (empty) | User profile search

the empty tabs are links to the normal user search page. If I comment the profileplus_menu() function supposed to hide the user tabs, and I clear the caches, I get the 3 tabs Content | Users | User profile search

I assume there is something wrong in profileplus_menu().

imi having the same problem as the guy above me also when i click on the profile search it doesnt even show anything..

After a bit of work, and some help to solve a few bugs, I have created an updated 5.x version of ProfilePlus. It handles multiple keyword searching, removes the Users tab (via code in template.php - unless someone can tell me a better way to do this), and can search both regular and custom user profile fields.

I am attaching the complete module, including .install, .info and README files rather than a patch. If someone wants a patch instead, let me know, but due to the many changes and inclusion of extra files, I thought this method would be better.

Had to fix a small bug when no search results were found. Tested on my system and everything should work well now. The install file also activated the Profile module if its not already on.

What is "/view" doing in the url variable on line 95?

$find[] = array('title' => $user->name, 'link' => url("user/$user->uid/view"), 'snippet' => search_excerpt($keys, $view));

This prevents path aliases to user profiles (via Pathauto, for example) from appearing properly in the results of a Profile Plus search.

Thank you for your work on this, but please attach a proper patch. The last gzipped attachment didn't have a patch in it.

I have finally figured out to do a multi-file patch, hence the lack of one in the last post. Anyway, here it is - patches the HEAD version with no problems for me (amazingly *grin*). For those who don't know what to do with it, use the following code in the folder where the HEAD version of the profileplus.module file is:

patch < profileplus5_2007-07-02.patch

Thanks for the tip about the "/view" code. Not sure why I put that in, but everything works (including aliases) fine without it now.

Thanks for a great module. Hopefully this patch will help in further development.

Thanks, incrn8! I'm marking this "needs review" for others who can look at your code now that you've made a patch. I haven't looked at it yet, but with your update in #6 being made into a patch (and including my small change in #7), I think this is almost RTBC.

Great! As soon as we get some feedback from yourself and others, I'll see what I can do about releasing a 5.x dev version. Just want to say thanks to hiweed for getting the ball rolling on this.

Hi, just wanted to notify you that I've been using this much-needed patch locally and it works great! I'll keep you posted if any problems crop up. I'd like to thank you incrn8 for putting this together; as far as I'm concerned this functionality should belong in the Drupal core :)

If all goes well, a 5.x release will be out soon. Thanks for the feedback.

New 5.x release is out.

Great stuff incrn8, your work is much appreciated.

You're welcome.