Better handling for partially in core cases [#903060]

Right now, when modules are partially in core, they are listed as "In core" with a warning icon next to it.

We decided that if notes exist for the module "in core" listing, it means the module is partially in core. This causes the warning icon to appear but does not change the "In core" text.

The solution should be that the notes also change the text to "Partially in core" and change the background to yellow.

Comments

Comment #1

philbar commented 5 September 2010 at 21:42

The issue with assuming "Partially in core" with notes is cases such as FileField which has a note saying it replaces "Upload". FileField has a note, but is fully "In core".

Comment #2

sun

German

Karlsruhe

commented 5 September 2010 at 21:54

I guess that Upload should be a note for Drupal core itself (when Upload is installed)... that, however, would result in the "Partially in core" status for Drupal core :P

Comment #3

philbar commented 5 September 2010 at 22:17

I think we should introduce "UPGRADE_STATUS_PARTIAL_CORE" and tag specific module with it.

Then instead of having the hackish:

    // US: Special handling for project moved into core.
    if (!empty($project['in_core_note'])) {
      $icon = theme('image', 'misc/watchdog-warning.png', t('warning'), t('warning'));
    }

We can have:

     case UPGRADE_STATUS_PARTIAL_CORE:
      default:
        $class = 'warning';
        $icon = theme('image', 'misc/watchdog-warning.png', t('warning'), t('warning'));
        break;