Closed (fixed)
Project:
EPSA Crop - Image Cropping
Version:
6.x-1.0
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Sep 2010 at 00:58 UTC
Updated:
6 Apr 2011 at 10:01 UTC
Jump to comment: Most recent file
Comments
Comment #1
jjwhitney commentedI second this suggestion. This would be great. You could also remove the "[Manage image crops]" link if there are no "presets used".
Comment #2
Odd Hill commentedThis is an issue we are having as well. We have a site with around 20 different Imagecache presets, and now we can't see them in the popup window. It's also very difficult for end users to understand the presets since imagecache only uses machine-readable names without any descriptions.
We would love to see this implemented. We use EPSA crop on all our installations
Comment #3
adr_p commentedSubscribing.
Is there already a way to narrow down available presets list? Like Odd Hill said, we also have a significant amount of imagecache presets and we simply cannot display them all on the form.
Comment #4
adr_p commentedAs I couldn't wait for the response I prepared a patch for the module.
The patch adds a new setting to the imagefield widget. Now admin can narrow down presets that can be cropped for each field individually.
Patch also recovers _epsacrop_get_crop_actions(), that disappeard from the 6.x-1.0 version. I'm sure it was there a couple of days ago...
Please feel free to test the changes and send me your comments. I'm waiting also for the bug reports.
Comment #5
adr_p commentedI've added an improvement and implemented a suggestion from jjwhitney to hide "[Manage image crops]" link where there are no presets enabled for a field.
You can get updated patch below.
Comment #6
yvmarques commentedHello,
Patch commited :) Thanks !
Regards,
-- Yvan
Comment #7
andrew_k commentedThanks guys, I'm looking forward to trying out this new feature
Comment #8
Odd Hill commentedAfter trying out this latest addition the cropping has stopped working. I'm getting this from the console:
$.Jcrop is not a function
/modules/oddmodules/epsacrop/js/epsacrop.js?T
Line 53
Comment #9
bensey commentedI had the same problem.
Realised that when I replaced with the dev version I hadn't added the json2.js nor the jcrop libraries to the new folder. Also needed to clear the cache to get it all working.
Works well, great job (and a great module!).
Comment #10
jjwhitney commentedThis is working great for me. Thanks!
Comment #11
andrew_k commentedIts working great for me too. an awesome new feature!
Comment #12
yvmarques commentedI've just release new version with the fix.
Thanks eveybody
-- Yvan