Split off from #903420: PHP notices in HS Taxonomy & HS - especially when running pressflow, this is an annoying notice popping up on a lot of occasions (especially with forms of course).
Very easy no brainer patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 905156-post-undefined.patch | 717 bytes | penyaskito |
| #10 | drupal-905156-10-form-post-isset.patch | 1.58 KB | mikeytown2 |
| #5 | form_notice_1.patch | 432 bytes | vectoroc |
| #4 | form_notice_1.patch.txt | 432 bytes | vectoroc |
| #1 | form_notice.patch | 547 bytes | swentel |
Comments
Comment #1
swentel commentedUpdated patch from root dir of Drupal and removing the other whitspace lines.
Comment #3
Raf commentedAny progress? I'm having this on Pressflow as well (along with some other bugs)
Comment #4
vectoroc commentedjust corrected a bit the patch
Comment #5
vectoroc commentedagain
Comment #7
damien tournoud commentedCan you elaborate on why you feel this is necessary? There is no reason for #post not to be defined.
Comment #8
vectoroc commentedBecause it produces a lot of notices in error_reporting(E_ALL) mode.
Perhaps it's an HS issue. I didnt investigate it deeply.
Comment #9
mikeytown2 commentedsubscribe from pressflow. Something like this would probably be better.
Comment #10
mikeytown2 commentedSetting to needs review for the testbot. Once it passes will switch this issue over to hierarchical select so we can come up with a proper fix in that module.
Comment #11
mikeytown2 commentedPatch above was green before moving this to the HS issue queue.
I believe the root issue is somewhere in the HS code base; thus I'm moving this issue into this project.
Comment #12
penyaskitoHaving the same issue, the problem is on hierarchical_select.module, line 690:
Removing this piece removes the problem, but I don't fully understand the implications.
Comment #13
penyaskitoOK, if I have understood the comment in code, the #post values where used instead of the #default_value.
If I remove this code, and load an edit form of a node with a hierarchical select, values are correctly set, so maybe those lines are not needed anymore?
Comment #14
penyaskitoAdding a patch.
Comment #15
goldTidying up the issue queue. The 6.x version is no longer supported. Only reopen this if it also applies to the 7.x.