Using several flickr drupal modules, there are multiple places to configure api keys etc.

If i crafted a patch to set this module to use the flickrapi module for api keys and calls to phpFlickr, would it be considered?

Comments

Anonymous’s picture

Hi Shiny,

That sounds like a great idea , looking forward to working with you on making this improvement to the flickr module .

Best, Paul

Anonymous’s picture

Perhaps we could begin by briefly documenting the proposed changes so that we encourage feedback from other
community members as early as possible .

Best, Paul

jdelaune’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev

I'd love to get Flickr using Flickr API as well. I'm happy to make the necessary changes to Flickr Field in D7, but I'd need someone to help with the other parts of Flickr. Then we can back port to D6 if needed.

I'll see what I can do on Monday and I'll post a patch.

BarisW’s picture

I can help with this. I'm co-maintaining the FlickrAPI module and I'm willing to work on a patch.
I've also done this for FlickrGallery: #1511996: Integrate with Flickr API

BarisW’s picture

Title: flickrapi.module » Integrate with Flickr API
Status: Active » Needs review

Patch attached. What is does is the following:

- Remove an old patch in the root of the repository
- Remove the admin interface to set the api key
- Move the page size settings to the FlickAPI admin form
- Transfer the current credentials to the FlickrAPI variables (so flickrapi_api_key instead of flickr_api_key)
- Add a check for existence of FlickrAPI using hook_requirements()
- Changed documentation

What I didn't change:
- I left all API-like functions intact. For example: flickr_photo_get_sizes() still exists but the function it calls (flickr_request) has been rewritten to use FlickrAPI.
- I did not change the logics and functionality of the current codebase. I found several things of which I think they could be improved (implementing Render Array for example) but I did not have time for that now.

You'll get a PHP notice if you have errors displayed on your dev environment, but that's an open issue from the OAuth module which is being worked on.

BarisW’s picture

Patch was missing.

BarisW’s picture

Made a minor type in hook_update_7100().
Here's a new patch. Did anyone review it yet?

lolandese’s picture

Status: Needs review » Reviewed & tested by the community

Tested the patch from #7. Works fine. Just a few notes:

  • The Flickr settings are taken over by the Flickr API module settings. The Default Flickr User Id is not used there anymore, so you have to set a Flickr ID in your block settings to avoid running into "Undefined.." errors.
  • The patch applied against the dev version fails to apply changes to the .info file. Use the git version. This is normal behaviour, not a bug of the patch. I couldn't find anything documenting this on d.o. Do you know a link covering this?
  • The Flickr API module uses the "new" OAuth. The "old" FlickrAuth will not be working anymore from the 31st of July 2012. I went through the code of the original module, but have no idea if the actual unpatched Flickr module uses the "old" authentication. Should we expect the original Flickr module not to be working anymore after 31 July? More info.

Please correct me if I'm wrong on anything.
Thanks Baris.

Taxoman’s picture

The Oauth issue mentioned in #5 was solved in April.
( #1515450: Use of undefined constant OAUTH_COMMON_TOKEN_TYPE_REQUEST in cache.inc )

lolandese’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs review

Meanwhile many changes took place, both in Flickr and in Oauth (Flickr API dependency).

dakku’s picture

Status: Needs review » Closed (outdated)