Closed (outdated)
Project:
Flickr
Version:
7.x-1.x-dev
Component:
flickr (main module)
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Sep 2010 at 00:07 UTC
Updated:
8 Oct 2019 at 09:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedHi Shiny,
That sounds like a great idea , looking forward to working with you on making this improvement to the flickr module .
Best, Paul
Comment #2
Anonymous (not verified) commentedPerhaps we could begin by briefly documenting the proposed changes so that we encourage feedback from other
community members as early as possible .
Best, Paul
Comment #3
jdelaune commentedI'd love to get Flickr using Flickr API as well. I'm happy to make the necessary changes to Flickr Field in D7, but I'd need someone to help with the other parts of Flickr. Then we can back port to D6 if needed.
I'll see what I can do on Monday and I'll post a patch.
Comment #4
BarisW commentedI can help with this. I'm co-maintaining the FlickrAPI module and I'm willing to work on a patch.
I've also done this for FlickrGallery: #1511996: Integrate with Flickr API
Comment #5
BarisW commentedPatch attached. What is does is the following:
- Remove an old patch in the root of the repository
- Remove the admin interface to set the api key
- Move the page size settings to the FlickAPI admin form
- Transfer the current credentials to the FlickrAPI variables (so flickrapi_api_key instead of flickr_api_key)
- Add a check for existence of FlickrAPI using hook_requirements()
- Changed documentation
What I didn't change:
- I left all API-like functions intact. For example: flickr_photo_get_sizes() still exists but the function it calls (flickr_request) has been rewritten to use FlickrAPI.
- I did not change the logics and functionality of the current codebase. I found several things of which I think they could be improved (implementing Render Array for example) but I did not have time for that now.
You'll get a PHP notice if you have errors displayed on your dev environment, but that's an open issue from the OAuth module which is being worked on.
Comment #6
BarisW commentedPatch was missing.
Comment #7
BarisW commentedMade a minor type in hook_update_7100().
Here's a new patch. Did anyone review it yet?
Comment #8
lolandese commentedTested the patch from #7. Works fine. Just a few notes:
Please correct me if I'm wrong on anything.
Thanks Baris.
Comment #9
Taxoman commentedThe Oauth issue mentioned in #5 was solved in April.
( #1515450: Use of undefined constant OAUTH_COMMON_TOKEN_TYPE_REQUEST in cache.inc )
Comment #10
lolandese commentedMeanwhile many changes took place, both in Flickr and in Oauth (Flickr API dependency).
Comment #11
dakku commented