Drupal 7 port (Views Fluid Grid)

Sure. Patch?

ah, noise then. Well, let's keep this as postponed. It will happen, but I do not know when because of lack of time... patches are welcome. Thanks

I got the module working on Drupal 7 with very little changes.

Looks good, 2 lines of trivial changes and works for me. Can we please have at least a 7.x-1.x-dev build?

I tried the two small changes to use it in 7 but it's not working.
It succeed to install it but when it doesn't allow me to select this kind of "Style". Any idea ?

I too did those changes independently and they worked out great. It is working for me.

Can we roll a dev version so we can track this module via the update report of D7?

Fixed by going back and looking at the Views 3 version of template_preprocess_views_view_unformatted(), which was the model for template_preprocess_views_fluid_grid_plugin_style() initially.

Sub

Which patch do I apply to make Views Fluid Grid work for Drupal 7? I tried the one from post #11 but it didn't work. At least not when I put the patch file in the module folder and patch it via Terminal on a Mac.
Thanks! :)

@Pillhuhn

How did you try to run the path? Which commands and what did it tell you?

Hello kannary100,

I downloaded the module and expanded it. Then I downloaded the patch from #10 and copied it into the View_Fluid_Grid module folder. I opened Terminal and opened the directory of the module folder (CD home/myfolder/downloads/ViewsFluidGrid). And then I ran the patch with: patch < 908920-views_fluid_grid-template_preprocess.patch.

This is what it looks like including the message from Terminal. I don't know enough about patching to decide whether I need the -p or -strip option as suggested in Terminal. Also, I am not sure what to enter for the 'File to patch:' question.

Last login: Sat Apr 30 22:22:49 on ttys000
Andres-MacBook-Pro:~ Andre$ cd /Users/Andre/Downloads/views_fluid_grid
Andres-MacBook-Pro:views_fluid_grid Andre$ patch < 908920-views_fluid_grid-template_preprocess.patch
can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/theme/theme.inc b/theme/theme.inc
|index 894e630..7dec86c 100644
|--- a/theme/theme.inc
|+++ b/theme/theme.inc
--------------------------
File to patch:

Well, and then I don't know...

Any pointers are appreciated. Thanks,
Andre

run the path command as on of these these two options

patch -p0 < 908920-views_fluid_grid-template_preprocess.patch

patch -p1 < 908920-views_fluid_grid-template_preprocess.patch

What is the difference between the p1 and p2 option?

Well, I tried both but I don't think it worked.

the -p0 option gave me the following:

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/theme/theme.inc b/theme/theme.inc
|index 894e630..7dec86c 100644
|--- a/theme/theme.inc
|+++ b/theme/theme.inc
--------------------------
File to patch: exit
exit: No such file or directory
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/theme/views-fluid-grid-plugin-style.tpl.php b/theme/views-fluid-grid-plugin-style.tpl.php
|index c8cf697..429a176 100644
|--- a/theme/views-fluid-grid-plugin-style.tpl.php
|+++ b/theme/views-fluid-grid-plugin-style.tpl.php
--------------------------
File to patch:
Skip this patch? [y] y
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 78
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/views_fluid_grid.info b/views_fluid_grid.info
|index 2a89e7e..71207ea 100644
|--- a/views_fluid_grid.info
|+++ b/views_fluid_grid.info
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 92
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/views_fluid_grid.module b/views_fluid_grid.module
|index c8cf69f..33ea23e 100644
|--- a/views_fluid_grid.module
|+++ b/views_fluid_grid.module
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored

and the -p1 option this:

Andres-MacBook-Pro:views_fluid_grid Andre$ patch -p1 < 908920-views_fluid_grid-template_preprocess.patch
patching file theme/theme.inc
patching file theme/views-fluid-grid-plugin-style.tpl.php
patching file views_fluid_grid.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file views_fluid_grid.info.rej
patching file views_fluid_grid.module
Reversed (or previously applied) patch detected! Assume -R? [n]

Git is now the preferred tool for creating and applying patches, although of course it brings with it the Git learning curve. Try the instructions here and let me know if you still have problems.

Subscribe

Hi Matthew,

I looked at the instructions but there seems to be now Git version for Mac OS X 10.6 Snow Leopard. Any ideas?

Thanks,
Andre

Subscribe

Subscribe

#10 looks good to go.
Could we have d7 branch and dev packaged to open to more people for testing?

Thanks @BWPanda. BTW, I happened to try applying a git-generated patch recently with:

patch -p1 < some.patch

... and it worked as it should.

-p1 patches are now the standard on d.o., so we've all got to learn to use `git apply`, get into the habit of using `patch -p1`, or if you only apply patches from d.o. maybe set a bash alias.

Thanks BWPanda, it works for me. Now it would be great to have an official Drupal 7 dev release.

subscribe

Subscribe!

+1 for official D7 dev release please.

subscribe

subscribe

#10 …lovely :)

subscribe

Hi all, thanks a lot for the patch and reviews. I have just created the branch, and soon will be adding a new dev release so it can be tested/used easily. Thanks!