Make parsed items accessible for modification

EDIT: see http://drupal.org/node/663860#comment-3462046

A reference accessor to each item individually along with an iterator.

This is no longer possible as the iterator class doesn't allow passing items by reference. So we should just make items public.

Works for me!

...but it seems patch in #4 was not made against the latest 6.x-1.x-dev. Please re-roll.

Here you go.

As you requested. The only thing I'm not sure of is $current_item and its associated shiftItem() and currentItem(). While it's pretty much the same to do:

while ($item = array_shift($batch->items)) {
  //awesome code here
}

That doesn't set current_item in the process. So what I'm thinking is leave FeedsImportBatch::shiftItem() but deprecate FeedsImportBatch::currentItem() and make current_item public. Also, the logic in currentItem() doesn't accomplish anything since array_shift will return NULL on an empty array.

This patch is currently broken because of the getRaw() methods on FeedsFileBatch and FeedsHTTPBatch. Those actually perform the reading when called. Will post another patch soon with the getRaw() method moved back.

All tests pass if #946822: FeedsSitemapParser broken: Serialization of 'SimpleXMLElement' is not allowed is included.

Subscribing

subscribe