There are certain importer configurations that are not exactly broken, but they simply don't make much sense:

- No mapping configured.
- Importer is used in 'standalone' mode while 'import on create' is not used (initially reported by andrewlevine #913080: Standalone import does nothing when "Import on create" unchecked)

We should implement such sanity checks, but we don't have much infrastructure in place for them right now.

I propose a feeds_check_configuration($importer) that returns an array of suggestions that we can print as a warning on an importer edit page, but also on the admin/build/feeds page.

Comments

alex_b’s picture

alex_b commented

More sanity checks:

- More than one importer attached to a single content type (this may be just handled as an error).
- A importer's data processor mapping off after cloning.

vasike’s picture

vasike
Location Ramnicu Valcea
commented

I hope that i'm in the right place.
It's about using the Standalone Form Settings in the Crons.
It works for a while then it stops working.
I make some changes (check/uncheck the import on create/try import manually) start again to work and so on ....

twistor’s picture

twistor commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
Assigned: Unassigned » twistor

After working on #1460282: Call to undefined method FeedsMissingPlugin::entityType() , #1213472: " Fatal error: Unsupported operand types in /FeedsConfigurable.inc" when importing, #1195484: Don't import items if parent feed is unpublished., I think this is greatly needed.

I'm thinking we need checks for Sources and Importers.

The importer sanity check would be similar to what Alex laid about above.
Source sanity checks would be used to determine if an import could run successfully and will depend on the importer sanity check as well.

megachriz’s picture

megachriz
Primary language Dutch
commented
Issue summary: View changes
Issue tags: +validation
Related issues: +#2320781: Validate feed importer configuration: check for invalid bundle and invalid language, +#2640108: Display an error message when attaching an importer to a content type that is already in use by an other importer

Closely related to #2320781: Validate feed importer configuration: check for invalid bundle and invalid language and #2640108: Display an error message when attaching an importer to a content type that is already in use by an other importer.

bluegeek9’s picture

bluegeek9 commented
Assigned: twistor » Unassigned
Status: Active » Closed (outdated)
Issue tags: -validation

Drupal 7 reached end of life and the D7 version of Feeds is no longer being developed. To keep the issue queue focused on supported versions, we’re closing older D7 issues.

If you still have questions about using Feeds on Drupal 7, feel free to ask. While we won’t fix D7 bugs anymore, we’re happy to offer guidance to help you move forward. You can do so by opening (or reopening) a D7 issue, or by reaching out in the #feeds channel on Drupal Slack.

If this issue is still relevant for Drupal 10+, please open a follow-up issue or merge request with proposed changes. Contributions are always welcome!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.