The 'CVS tree' field really has no business being in project.module. And, it's actively going to be a problem once we migrate to Git.
See these issues for more:
#913996: Wipe out all the "CVS Tree" links on d.o projects so they're set correctly automatically
#435528: Display link to drupalcode.org repository for "Browse the CVS repository" by default
#156118: Automatically generate the value of 'Link to webcvs/viewcvs' field for a project
I think we should just remove this field from project nodes entirely and drop the data from the DB. Tell sites that are upgrading that if they want to keep this data, they should add a CCK field for it or something.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 913998-6.no_cvs_tree.patch | 9.45 KB | dww |
Comments
Comment #1
avpadernoTo remove it seems a better solution, to me. On Drupal.org, if users need the link to the CVS repository, they can look into the log of the CVS commits; that is what you need to do, anyway, for the projects that don't use that field.
Comment #2
dww@kiamlaluno: You're confused. On d.o we're going to have the link, which is different than the "View CVS messages" link. We now have it on all projects that don't define it for themselves. #913996: Wipe out all the "CVS Tree" links on d.o projects so they're set correctly automatically is talking about changing that so that the link is always defined correctly, regardless of what the project maintainer puts in the field.
*This* issue is about removing the field entirely, since it's just 8+ year old cruft that doesn't really belong in this module. It should have been added via cvs.module in the first place, instead of hard-coded in here.
Comment #3
avpadernoIf the link to the repository is still present because it is automatically generated, that is good; it is better than to have a field that must be filled by project maintainers, who leave it blank in many cases.
If the link to the repository is not present in the project page, then that doesn't change the situation for those projects that don't show it; for who really needs to know the link, it is still possible to get it from the CVS messages (and from the GIT messages, I guess).
I didn't mean that the link to the CVS messages is the link to the CVS tree.
Comment #4
dww@kiamlaluno: One of us is confused. ;) I guess now I'm confused what you're trying to say.
I'll try to say what I'm saying again as clearly as I can:
We *want* this link for end users IFF the project has code that lives in a version control repository. It's lame for end users looking at the project page to only sometimes get this link, potentially have the link be wrong, or to have to figure out how to find this link from the "View CVS messages" page. However, it's stupid for the maintainer to have to define this link manually, since whatever integration we have with version control should be able to provide this link automatically.
Right now, on d.o, it's a site-specific hack in drupalorg.module thanks to #435528: Display link to drupalcode.org repository for "Browse the CVS repository" by default
It should be handled by cvs.module over at #156118: Automatically generate the value of 'Link to webcvs/viewcvs' field for a project but it's pointless to spend more time on cvs.module right now with the move to versioncontrol API.
No matter what, it's stupid for project.module to provide this as a manual field on project nodes. That's what *this* issue is for.
Comment #5
dwwThis keeps coming up in community testing, so I'm going to crank out a patch right now. Stay tuned.
Comment #6
dwwI didn't add a DB function to automatically drop this column from the {project_projects} table. I'm worried about killing data people want to keep. So, for now it's at least totally gone from the UI.
Comment #7
dwwCommitted to HEAD. See also #1029398: Drop the {project_projects}.cvs column and document it for upgrades