Closed (fixed)
Project:
Feeds
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2010 at 02:03 UTC
Updated:
30 Jun 2011 at 18:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Onfire60 commentedComment #2
alex_b commentedThere isn't.
Postponing this issue. Feel free to set to active if you'd like to work on this.
Comment #3
arski commentedwould love to have this too. Is it somehow trickier than just the username or email field?
Comment #4
willieseabrook commentedsubscribe
Comment #5
willieseabrook commentedSee attached patch. Only works if pass is plain text.
Due to the way user module md5s ->pass no matter what, would be a little extra to do an additional update after insert to manually update an md5 encrypted pass.
If theres any demand for that ping me. For now all i need is plain text.
Comment #6
micheleannj commentedAwesome timing -- thanks!
Comment #7
Anonymous (not verified) commentedGood approach. This patch (in #5) is very simple and taps into Drupal's existing security framework. Thanks!
Comment #8
jackbravo commentedSeems like this has not been ported to D7 version.
Comment #9
kehan commentedsubscribing and +1 for d7
Comment #10
jyee commentedPatch from #5 updated for Feeds 7.x-2.0-alpha3
Same file, same code, different line numbers... seemed to work in my basic testing.
Don't Use This File, See Following Comment
Sorry folks, forgot I was on my own site git repository and not from the Feeds git. This file isn't Drupal standards compliant (although it should work if your site is in Git and Feeds is in sites/all/modules/contrib/feeds
Comment #12
jyee commentedUpdated patch using the git 7.x-2.x branch of Feeds. Previous patch file was incorrectly generated.
Comment #14
jyee commentedAutomated test failing because there's no feeds_test... seems like an issue with the automated tester and not this patch. Setting back to 'needs review' for actually reviewing and testing.
Edit:
For those who don't want to apply a patch, you could simply create a module with this code in the .module file:
Where HOOK is the name of your module
Comment #15
Antoine Lafontaine commented@willieseabrook
Your patch in #5 works great, but I'm also quite interested in a solution for importing already md5'ed passwords. You seem to be hinting for a solution. Would you care sharing it?
Thanks.
Comment #16
Antoine Lafontaine commentedHad a try at the problem myself and came with the following solution, wrapped in a small custom module.
The tricky part was to actually get the MD5'ed password converted to the new Drupal 7 hash.
That part of the code is based on the user_update_7000 code available here: http://api.drupal.org/api/drupal/modules--user--user.install/function/us...
This is not a patch for the module and it is not tested outside of my own requirements.
Hope this can become a base for a solution.
If the maintainers of the module would like me to try writing a patch, I don't mind trying (not much experience)
Comment #17
mark trappSubscribe. #12 look good to me; I'm planning on putting it through its paces on 1,700 users tonight, but it should be RTBC.
Comment #18
kehan commentedI used #12 on an import of 14000 users without any hiccups. I'd say RTBC as well
Comment #19
mark trappWorked like a charm.
Comment #20
dave reidThis should probably add some kind of test to FeedsCSVtoUsersTest to ensure it works properly.
Comment #21
dave reidComment #22
dave reid#21 passes locally, so committing to Git: http://drupalcode.org/project/feeds.git/commit/b9dd6a0
Comment #23
dave reidCommitted and manually tested on 6.x-1.x: http://drupalcode.org/project/feeds.git/commit/5e9dedc