Posted by Alan D. on September 18, 2010 at 11:22pm
6 followers
| Project: | PageFlip: Book, Magazine, Comic Viewer |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | adamdicarlo |
| Status: | closed (fixed) |
Issue Summary
I've attached the complete patch for each of the following issues:
#859712: Depends on jquery.ba-hashchange.js & jquery.cycle.js -- add libraries dependency
#864172: Documentation required for installation and usage.
#900188: Missing dependency on Imagefield and Filefield
#900190: Use hook_node_info to setup content types
#900196: Imagecache integration
#900198: Creating a book is confusing -- add hook_help().
And the code has also been run through Coder module to clean up & address any issues (All very minor).
This requires some testing and an upgrade warning about the changed JScript file locations.
Apologies for the big hit, but maintaining multiple patches against head would have taken more time than I had assigned to this task.
| Attachment | Size |
|---|---|
| combined.patch | 52.98 KB |
| pageflip.zip | 29.94 KB |
Comments
#1
Hello there:
I've installed http://ftp.drupal.org/files/projects/pageflip-6.x-1.0-beta1.tar.gz and some errors appeared (ex: foreach).
Then i saw this post but i dont know how to apply this files.
Do i have to patch using "ssh shell to my webserver"
or
replacing the files on the "modules folder" by the ones inside this zip will do it?
#2
It would be best to wait for the maintainer response. I do not know how many of these issues they will use / apply to the module. And I still have to production test things with the modified module, which will happen in the next couple weeks sometimes. Also the zip above doesn't contain the fixes for the issue #900874: PageFlip cause CCK foreach error? that I also gave a fix for too.
Maybe PM the maintainer to see if they can review the queue, namely #900874: PageFlip cause CCK foreach error? & this one to start things moving.
Alan
#3
Thanks for your reply Alan D.
I have also posted on megazine forum:
http://www.megazine3.de/forum/index.php/topic,1219.0.html
#4
I meant emailing the maintainer via http://drupal.org/user/100783/contact but that may work to :)
#5
Hey there, Alan -- thanks so much for the patches! I'll try to merge your big patch into my working copy (the code on the client's site is a bit newer than official "beta1" release) as soon as I can! BTW, sorry about the delay, I need to change my gmail filters so I don't miss the issue notification messages.
edit: ergh, I wasn't autosubscribed to the issue queue. now I'm subscribed!
#6
#7
Hoping that you will like most of it. The setup is so much easier now!
I think I looked at one last thing (it has been a while), but the attached zip is as up to date as I got with it. I still had 4 hours integration with a site left, but it looks like it is going over the budget too much and we may not implement this sadly.
#8
Hmm, it'd be easier to track any bugs if I first commit the latest (client's version) first and then merge your changes in steps.
Thanks again and in particular for the README and content type creation code! Nice not to have to make Features a dependency for that.
#9
Cool, glad you found them useful. I felt like I was hogging the project issue queue at the time.
#10
Alan, I won't be able to get to integrating the other patches for a few days but I do plan to integrate them. Note that I checked in a bunch of new features before starting merging/committing your patches. I'd like to roll a beta2 once I finish with your patches. I do hope you get to use PageFlip in your client work!
#11
Hello again:
I've updated to the "pageflip_0.zip patch" but still can't use flash to view the book:
(Please install flash to view this page.)
It's better than foreach() errors but still cant visualize the book with the megazine engine.
Any ideias?
#12
I saw the dev version and gave it a try.
No luck. Now appears:
(
Or select a resolution for the non-Flash version:
1280x720 or 1920x1080)
I'm not capable of debugging this. Sorry.
#13
Primobruno, PageFlip outputs the Flash object in the footer region. If your theme doesn't have a footer region, no Flash will be present. Also, now that you have the dev version, visit your admin reports page and see if the PageFlip dependencies are satisfied. If the MegaZine javascript and Flash files are not in the exact right place, then you'll just see that message.
PageFlip always outputs that message, but it also outputs the Flash player to cover up that message. (So that "error" message is always hiding behind the Flash, even when nothing's wrong.)
If you have any more problems please create a new support issue or comment on an existing issue that seems related.
#14
I have tried the pending patch, and patched the cck thing.
I have created pages, chapters and a book called "ccc".
Next I want to see the flippage book with the HTML viewer:
http://localhost/drupal/?q=content/ccc-0#
If we take a look at the source, we see the ?q= in the url pointing to the jpg.
img width="640" height="720" src="http://localhost/drupal-inca/?q=sites/default/files/pageflip/pages/640x1080_0.jpg" /
http://localhost/drupal-inca/?q=sites/default/files/pageflip/pages/640x1... => Page not found
http://localhost/drupal-inca/sites/default/files/pageflip/pages/640x1080... I can see the jpg
I can see empty pages, and flip them, but the url to access the jpg seems to be "broken"...
#15
have you got public or private file settings?
#16
It is solved now: I think "clean urls" must be enabled.
#17
Committed cleanup: http://drupal.org/cvs?commit=450530
Committed content type creation: http://drupal.org/cvs?commit=450566
#18
#19
Could someone please give us an update on the "PageFlip cause CCK foreach error?" issue? http://drupal.org/node/900874
It seems to be discussed here as part of this patch, but now we're up to 6.x-10-beta4 and I'm getting the same issue crop up.
#20
@afestein I've fixed the CCK foreach error and rolled a new beta (6.x-1.0-beta5).
I'm closing this issue as it was a wrapper for a bunch of issues which are all fixed.
#21
Thanks for your prompt attention.
#22
Automatically closed -- issue fixed for 2 weeks with no activity.