Don't include Modernizr and HTML5 shiv at the same time

We should use phptemplate if statements style.

So instead of

<?php // Add HTML5 shiv if Modernizr is not included 
 if (!theme_get_setting('html5_base_modernizr')) { ?>
 <!--[if lt IE 9]><script src="http://html5shiv.googlecode.com/svn/trunk/html5.js"></script><![endif]-->
<?php } ?>

it should be

<?php if (!theme_get_setting('html5_base_modernizr')): ?>
  <!--[if lt IE 9]><script src="http://html5shiv.googlecode.com/svn/trunk/html5.js"></script><![endif]-->
<?php endif; ?>

ericduran is right, phptemplate does generally use the alternate syntax.

alanburke raises a good point about the documentation. The coding standards are for straight PHP files, and I don't know if the phptemplate differences are documented.

Yeah, the coding standard are for the modules/php files.

Phptemplate files usually use the alternate syntax. I swear I've seen this documented before but I did a quick search and couldn't find anything. But yes the alternate syntax is the correct way for template files. This is excluding the template.php file as that's an actual php file.

As much as I prefer the standar php if syntax, all the themes I've worked on or inherited use the alternate syntax.

I've committed the change.

I certainly don't mind doing that. Do you know if I have to do anything special? Or just credit folks in the commit message?

There are instructions here.

thanks, Tim