Usability: set farbtastic form focus to base color after selecting a preset color choice [#91985]

Comment	File	Size	Author
#22	farbtastic-scheme-focus-91985-22.patch	512 bytes	babruix
#17	farbtastic-scheme-focus-91985-17.patch	997 bytes	bdragon
#10	color_6.patch	525 bytes	bdragon
#4	color.js_0.patch	504 bytes	Gurpartap Singh
#1	color.js.patch	635 bytes	Gurpartap Singh

Status	File	Size
new	color.js.patch	635 bytes

Comment #3

Gurpartap Singh commented 30 October 2006 at 15:46

Here's a patch working as expected, better.

Log in or register to post comments

Comment #4

Gurpartap Singh commented 30 October 2006 at 15:46

Status	File	Size
new	color.js_0.patch	504 bytes

all my posts, sorry :(

Log in or register to post comments

Comment #6

Gurpartap Singh commented 12 December 2006 at 10:51

Anyone getting this?

Log in or register to post comments

Comment #7

forngren commented 5 January 2007 at 16:09

Can you please explain better what you want do achieve? Perheps I'm just stupid, but I simply don't get it.

Log in or register to post comments

Comment #8

drumm

he/him

NY, US

commented 31 January 2007 at 07:07

Version:

5.x-dev

» 6.x-dev

Log in or register to post comments

Comment #9

hass commented 3 October 2007 at 19:08

Status:

Needs review

» Needs work

Patch in http://drupal.org/node/91985#comment-150501 contains leading tabs. Please change to two spaces per tab.

Log in or register to post comments

Comment #10

bdragon commented 26 October 2007 at 14:41

Status:

Needs work

» Needs review

Status	File	Size
new	color_6.patch	525 bytes

Free reroll (with proper whitespace), courtesy patch bingo.

Log in or register to post comments

Comment #11

birdmanx35 commented 28 January 2008 at 03:05

Version:

6.x-dev

» 7.x-dev

Feature request, -> 7.x-dev.

Log in or register to post comments

Comment #12

robin monks commented 1 September 2008 at 11:36

Status:

Needs review

» Postponed (maintainer needs more info)

Patch still applies, but, I still don't see what it's trying to achieve. Making needs more info until that can be explained.

Robin

Log in or register to post comments

Comment #13

Gurpartap Singh commented 1 September 2008 at 15:40

Consider:

a) A color preset is selected. say bluemarine.
b) Color fields now have new/changed values.
c) But the selection in farbtastic is still pointing to some earlier selection (viz not the same as bluemarine's base color).

The patch sets farbtastic color widget's color selection to selected preset's base color when this preset is selected.

Log in or register to post comments

Comment #14

robin monks commented 1 September 2008 at 15:53

Title:	Change farbtastic sel. on Color set choice	» [usability] Set farbtastic form focus to base color after selecting a preset color choice
Status:	Postponed (maintainer needs more info)	» Needs work

Thank you for the description of the problem. I have updated the title to better reflect the issue as you have described it in comment #13. If you feel this was in error, please feel free to update the title again, it is your issue after all :o)

I'm returning the patch to code needs review as when I tested focus remained on the color preset selector even after selecting another preset.

Robin

Log in or register to post comments

Comment #15

dmitrig01 commented 1 September 2008 at 21:14

Title:	[usability] Set farbtastic form focus to base color after selecting a preset color choice	» Usability: set farbtastic form focus to base color after selecting a preset color choice
Component:	color.module	» usability