Hi there,

Thanks 4the module- saved a lot of work..
- well, will save a lot of ppl a lot of work in the future :)

[Using message template]

I think, in hook_mail_alter :

$ss__value = _get_field_setting($as__field[0], $message['params'][$as__field[$i]]);

needs to be:

$ss__value = _get_field_setting($as__field[$i], $message['params'][$as__field[$i]]);

Now get_field_settings will get the fields value from the first field - should be from the current field, i.e. as_fields[$i]

Regards,

Lanceo

Comments

beautifulmind’s picture

beautifulmind
he/him
Primary language Gujarati
Location Dubai
commented

Hello,
Thanks for using the module and I'm glad its helping you. Also, I'm thankful to you for such a nice review of the code. I'm definitely consider this and gonna give enough time to fix all the issues related to message template. In face, I'm considering lots of suggesions and fixing the issue with the message template. I really appreciate that you point out the bug. Thanks for that.

Again, I'm very much thankful to you.

Regards.

beautifulmind’s picture

beautifulmind
he/him
Primary language Gujarati
Location Dubai
commented

Hello,
Please try the latest dev version and let me know if the issue still persists.

Regards.

beautifulmind’s picture

beautifulmind
he/him
Primary language Gujarati
Location Dubai
commented
Status: Active » Closed (fixed)
ani7a’s picture

ani7a commented

As i see in version:

; Information added by drupal.org packaging script on 2011-02-25
version = "6.x-2.x-dev"
core = "6.x"
project = "contact_field"
datestamp = "1298619017"

The problem in contact_field.module is still there.... in line 326:
for ($i = 0; $i < count($field); $i++) {
$ss__value = _get_field_setting($as__field[0], $message['params'][$as__field[$i]]);
$am__value["!". $as__field[$i]] = $ss__value;
}

Instead of
for ($i = 0; $i < count($field); $i++) {
$ss__value = _get_field_setting($as__field[$i], $message['params'][$as__field[$i]]);
$am__value["!". $as__field[$i]] = $ss__value;
}

Thanks for the module!

ani7a’s picture

ani7a commented
Status: Closed (fixed) » Needs review
beautifulmind’s picture

beautifulmind
he/him
Primary language Gujarati
Location Dubai
commented

Hello,
Thanks for drawing attention.
The changes are underway.

Regards.

beautifulmind’s picture

beautifulmind
he/him
Primary language Gujarati
Location Dubai
commented
Status: Needs review » Closed (works as designed)