There is many changes to the selection mode, but most of it is just refactoring. The summary of the changes on consequence is swapping out the 1-click links for submit buttons, so we can still have one-click functionality with a tradition form submission.

CommentFileSizeAuthor
#2 decisions-1-click.2.0.0.patch26.82 KBjudahtanthony
decisions-1-click.2.0.patch22.21 KBjudahtanthony

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Needs work

Could you explain your motivation here, and also provide a patch according to the instructions at http://drupal.org/patch/create ? Thanks!

judahtanthony’s picture

judahtanthony commented
Status: Needs work » Active
StatusFileSize
new decisions-1-click.2.0.0.patch26.82 KB

Different version of the patch.

judahtanthony’s picture

judahtanthony commented

The original motivation is from a base line conviction that static content should be requested through the GET (or HEAD) method, and any request that changes the state of the app should go through POST (or PUT or DELETE). But This thought prompted me to do a little investigation on a voting implementation I was working on, and I found a bug.

We were allowing voting for anonymous users (which I'm sure you know can be problematic). What I found was the GET calls were bouncing of our proxy cache (Varnish). They returned a response that made it appear the vote went through, but in fact it didn't. I believe an anonymous user would fall into this same trap with Drupal page cache alone.

The solution I propose is to use POST as most proxies (and Drupal page cache) will not server a cached page on a POST request.

ezra-g’s picture

ezra-g commented
Status: Active » Needs review

Marking as "needs review"