Drupal Queue integration in Job Scheduler for Drupal 6 is quirky: it expects the API user to declare a Drupal Queue of the same name as the callback of the job schedule and thus choose whether a job callback should be executed by the job scheduler or merely queued for later execution.
This needs to be fixed and is actually a bug, because it confuses the concepts of queue name with callback functions.
Patch coming.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 922702-8_queue_integration.patch | 15.53 KB | alex_b |
| #7 | 922702-7_queue_integration.patch | 15.71 KB | alex_b |
| #6 | 922702-6_queue_integration.patch | 15.25 KB | alex_b |
| #5 | 922702-5_queue_integration.patch | 15.3 KB | alex_b |
| #4 | 922702-4_queue_integration.patch | 15.01 KB | alex_b |
Comments
Comment #1
alex_b commentedThis fixes the abovementioned issues for Drupal 7. Most importantly, job schedules need to be declared in a hook now, this is in analogy to how drupal's queue works. Compare this hook to hook_cron_queue_info().
Comment #2
alex_b commentedImproves the example in the hook documentation.
Comment #3
alex_b commentedFurther unify concepts of queue and scheduler.
- One object per scheduler identified by $name.
- Hence, move cron dispatching routine out of class into module.
- JobScheduler::get($name) instead of job_scheduler($name).
Also updated README.txt and job_scheduler.api.php accordingly.
Comment #4
alex_b commented- Fix a couple of typos.
- Remove semaphore. The scheduling routine being time based plus the recovery of stuck scheduled flags should make this unnecessary.
Comment #5
alex_b commentedFix: only reserves job when using the queue.
Comment #6
alex_b commented- Fix some typos
- Move exception that gets thrown when no scheduler info can be found to dispatch() - allows for scheduling items that don't have an info callback declared /yet/
Comment #7
alex_b commentedFixed further typos. This is very close now. Will need an update to Feeds.
Comment #8
alex_b commentedThis is tested now, will commit soon together with an according commit to Feeds.
Compatibility patch http://github.com/lxbarth/Feeds/commit/ff48db14abc57cc5801d92001263f7365...
Comment #9
alex_b commentedThis is committed now. Needs to be ported to Drupal 6.
Comment #10
alex_b commentedComment #11
kyle_mathews commentedHas there been any progress on porting this patch to Drupal 6? I have a module I'd like to write that will be based on job_scheduler. This module isn't a super high priority at the moment but I could start if this patch were in.
Comment #12
alex_b commented#11: should be fairly easy to back port. I haven't started on it at all though.
Comment #13
apramakr commentedHi there!
Is there available an updated version of this module (along with this patch) for Drupal 6? I need this module in order to proceed with the Feeds module.
I would appreciate if this can be backported to Drupal 6 and comitted soon..
Thanks so much!
Comment #14
d.sibaud commentedwaiting for the backported patch me too. Good work.
Comment #15
jim kirkpatrick commented+1 for D6 version...
Comment #16
sepla commentedSubscribing..
Comment #17
miurahr commentedI'd try to made ubuntu/debian package for job scheduler/ctools/feeds modules for D6.
subscribing
Comment #18
tyler-durden commentedIs this why I cannot get Drupal Queue to work with Drupal 6 and Feeds Beta 9?
Comment #19
virtuali1151 commentedHas this been back ported to 6 yet by chance?
Comment #20
brycesenz commentedsubscribing.
Comment #21
notasheep commentedsubscribing
Comment #22
jmwhitco commentedSubscribing.
Comment #23
Robin Millette commentedGuys, no need to subscribe anymore. Follow instead. Thanks!
Comment #24
twistor commentedI'm going to go ahead and say this is not backport worthy anymore.
If someone wants to post a patch, I'd be happy to review it.
Comment #25
mikran commented#24, in that case the bolded warning on project page should be removed / updated to reflect this.
Comment #26
intrafusion