Hey! I installed the news version of feeds an of the job_scheduler, but I got this error on cron-run:
Fatal error: Call to a member function import() on a non-object in /sites/all/modules/contrib/feeds/feeds.module on line 67
Please help me!

CommentFileSizeAuthor
#2 923318-2_avoid_fatal_error.patch1.55 KBalex_b
#1 923318-1_avoid_fatal_error.patch692 bytesalex_b

Comments

alex_b’s picture

alex_b commented
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new 923318-1_avoid_fatal_error.patch692 bytes

What's happening is that you have invalid sources in your feeds_source table.

This happens if you e. g. configure an importer with a standalone form, upload through that form (produce a source of feed_nid=0), then attach that importer to a content type. Or vice versa: you create an importer attached to a content type, upload through a node of that content type (produce a source of feed_nid=[nid]), then reconfigure to use th standalone form. In these circumstances, the created sources kept importing. The newer version of Feeds avoids that by checking whether a source 'exists' and is 'valid' - see FeedsSource::existing().

There is an exception missing in this routine though. This is critical, we should get out a fix fast.

alex_b’s picture

alex_b commented
StatusFileSize
new 923318-2_avoid_fatal_error.patch1.55 KB

I actually think we should fail silently in such situations. "Phantom sources" are not per se a problem, we should just make sure that we don't import them periodically.

alex_b’s picture

alex_b commented
Title: Error during cron run. » Fix fatal error occuring on cron
Version: 6.x-1.0-beta8 » 6.x-1.x-dev
Status: Needs review » Fixed

This is committed, thank you for reporting.

http://drupal.org/cvs?commit=427746

chweb’s picture

chweb commented

Thank you for the very fast fixing and committing, thats awesome!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.