Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hey! I installed the news version of feeds an of the job_scheduler, but I got this error on cron-run:
Fatal error: Call to a member function import() on a non-object in /sites/all/modules/contrib/feeds/feeds.module on line 67
Please help me!
Comment | File | Size | Author |
---|---|---|---|
#2 | 923318-2_avoid_fatal_error.patch | 1.55 KB | alex_b |
#1 | 923318-1_avoid_fatal_error.patch | 692 bytes | alex_b |
Comments
Comment #1
alex_b CreditAttribution: alex_b commentedWhat's happening is that you have invalid sources in your feeds_source table.
This happens if you e. g. configure an importer with a standalone form, upload through that form (produce a source of feed_nid=0), then attach that importer to a content type. Or vice versa: you create an importer attached to a content type, upload through a node of that content type (produce a source of feed_nid=[nid]), then reconfigure to use th standalone form. In these circumstances, the created sources kept importing. The newer version of Feeds avoids that by checking whether a source 'exists' and is 'valid' - see FeedsSource::existing().
There is an exception missing in this routine though. This is critical, we should get out a fix fast.
Comment #2
alex_b CreditAttribution: alex_b commentedI actually think we should fail silently in such situations. "Phantom sources" are not per se a problem, we should just make sure that we don't import them periodically.
Comment #3
alex_b CreditAttribution: alex_b commentedThis is committed, thank you for reporting.
http://drupal.org/cvs?commit=427746
Comment #4
chweb CreditAttribution: chweb commentedThank you for the very fast fixing and committing, thats awesome!