After submitting a new revision, the pending revisions notification message is shown twice (see screenshot)

CommentFileSizeAuthor
#8 revision_moderation-nodewords.patch4.01 KBjohn morahan
#5 revision_moderation-4.7.x-duplicate_messages_0.patch858 bytesjohn morahan
#4 revision_moderation-4.7.x-duplicate_messages.patch3.7 KBjohn morahan
screenshot_015.86 KBmarcoBauli

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Can anyone reproduce this? I haven't seen this in my tests.

jimmygoon’s picture

jimmygoon commented

I can't say I've ever seen it in any of my testing...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Closed (fixed)

I'm going to mark this closed. Please feel free to re-open if you can give me instructions on how to reproduce.

john morahan’s picture

john morahan commented
Version: master » 4.7.x-1.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new revision_moderation-4.7.x-duplicate_messages.patch3.7 KB

It happens for me with the 4.7.x versions, but not with 5.x-1.0

Here's what I changed to fix it.

john morahan’s picture

john morahan commented
StatusFileSize
new revision_moderation-4.7.x-duplicate_messages_0.patch858 bytes

for clarity, the same patch without the whitespace changes

ashtonium’s picture

ashtonium commented

I was actually seeing this in the 5.x version as well, when I was viewing the full node this message would sometimes display twice--both linking to the same revision.

I entered this fix by hand and it appears to have solved the problem.

john morahan’s picture

john morahan commented
Version: 4.7.x-1.x-dev » 5.x-1.x-dev
Status: Needs review » Patch (to be ported)

Okay, I think I've figured it out - on the 4.7.x site I had the Meta Tags module (aka nodewords) installed, but not on the 5.x site. I installed both Revision Moderation and Meta Tags on a 5.x test site and got this problem there too. So it seems that this is a conflict between these two modules. Can anyone else confirm this?

john morahan’s picture

john morahan commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new revision_moderation-nodewords.patch4.01 KB

Here's a patch for 5.x-1.x-dev

john morahan’s picture

john morahan commented
Title: Pending revisions message shown twice » Pending revisions message shown twice when Meta Tags module is installed
ashtonium’s picture

ashtonium commented

Yes, I do have the Meta Tags module installed on the site I'm seeing this issue on.

Mac Clemmens’s picture

Mac Clemmens commented

Confirmed... I have the same issue. Thanks for this patch!

add1sun’s picture

add1sun commented

this one is odd. I'm not familiar with nodewords to know why setting the !teaser fixes it. I'd rather not add lines of code unnecessarily so I'd like to see if this is still a conflict (also if in D6) and then why this change fixes it. :-) Any insights?

add1sun’s picture

add1sun commented
Status: Needs review » Postponed (maintainer needs more info)

Still happens in 5 but doesn't happen for me in 6. I poked at that part of the code and it looks like it was a fix that slipped in to makara's D6 "upgrade" patch. I'd still really like to know *why* nodewords is making this happen to determine if it is RM's fault or nodewords' fault before I commit.

add1sun’s picture

add1sun commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Postponed (maintainer needs more info) » Fixed

Ugh, OK I think I figured it out - sorta. It is the nodewords' "Use the teaser" setting to use the teaser to set a description, which is turned on by default. The RM message is displayed in both the teaser and the full node view. NW is pulling the node to get the teaser for its "description" which ends up firing the dsm twice, once for the NW description getting set and then once for the regular node view.

Honestly I think this is a nodewords problem and not a RM bug. On the other hand should/do we want the pending revisions notice to appear in teasers? Probably not.

Committed to 5, 6 and HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.