Improve drupal_*_css examples

Plese read the theme update page for information on drupal_add_css(). If you want to insert a new stylesheet in your theme, you can do so by simply adding the HTML code for it after <?php print $styles; ?>. If you want to use drupal_add_css() to add your theme-specific styles, you have to recalculcate $styles by calling $styles = drupal_get_css();.

How about if you want to override a 'core' or 'module' style? Just adding with html won't maintain the right order unless you copy and manage it in your single "style.css" file. But even with that you could end up with core styles coming after module styles. Not really a big deal most of the time but it does break the point of proper cascading order of the new system.

For themers (like me), it's very confusing. I ran into the same issue but I worked around it by manually adding to the $css array from template.php similar to this..

function _phptemplate_variables($hook, $vars = array()) {
  switch ($hook) {
    case 'page':
      $defaultsCSS = drupal_get_path('module','system') .'/defaults.css';
        if ($vars['css']['core'][$defaultsCSS]) {
          unset($vars['css']['core'][$defaultsCSS]);
          // Manually push into the array.
          $vars['css']['core'] = path_to_theme() .'new-defaults.css';
        }
  }
  return $vars;
}

Oddly enough, if you call drupal_add_css inside $hook->node it works properly. It gets called earlier so there's something about the order of that function call preventing it from working inside "page".

If this is by design then it should be reconsidered. My head turned to knots trying to figure this out.

Whoops, I mean this as it's a multi-dimentional array.

// get new file and manually push into array.
$newDefaults = path_to_theme() .'new-defaults.css';
$vars['css']['core'][$newDefaults] = array('path' => $newDefaults, 'media' => 'all');

Did you actually *read* the link I posted? $css is only used if you use it in your theme. If you don't have a drupal_get_css($css); somewhere in your theme, this is completely useless. The rendered version of that array is at $styles. So after adding a file, you have to recalculate this string.

PHP offers functions to insert an element before another element in an array. That will do it.

Yeah kkaefer, I did *read* that page and I am calling it through drupal_get_css($css).

Look at the last comment by me in that upgrade handbook and try running the code. It's very inconsistent.

I don't think it's critical but this the way it's supposed to work?

@hass

You can do something like this for now.

function _phptemplate_variables($hook, $vars = array()) {
  switch ($hook) {
    case 'page':

      $layoutTest = path_to_theme() .'/css/layout_test.css;
      // Append $layoutTest to the beginning of 'theme' group.
      array_unshift($vars['css']['theme'], $layoutTest = array('path' => $layoutTest, 'media' => 'all'));
      
      break
  return $vars;
}

There should be a way to give weight to each style but that's another issue.

Bah!!

I meant this to *prepend* to the beginning of theme group.

$layoutTest = path_to_theme() .'/css/layout_test.css;
array_unshift($vars['css']['theme'], $layoutTest = array('path' => $layoutTest, 'media' => 'all'));

It is not inconsistent. PHP is not magic.
$css is a variable defined by the phptemplate engine. Subsequent calls to drupal_add_css or drupal_get_css do not magically change this $css variable.

Fine, maybe it's not but look at it from a themer's point of view. It looks inconsistent. Just follow that section and try adding a css file the way it's shown. Then the immediate code example for unsetting a css file. When it's called through "drupal_get_css($css)" it looks like drupal_add_css() doesn't do a damn thing.

I found a workaround but that part should be made more clear if this is really the way it's intended to work.

Then this is a documentation issue.

Better title.

Okay, a small list for anyone who can update the doc. I know it's obvious to some but we all can't be so smart.

1. drupal_add_css() shows the added style when calling drupal_get_css() -without $css.
2. Manually unsetting a style then you must call it with $css, e.g. drupal_get_css($css).
3. If you must do both then it's all manual then making the call through drupal_get_css($css).
   for page.tpl.php:

   unset($css['type']['path']);
   $css['type']['newpath'] = array('path' => 'newpath', 'media' => 'all');
   print drupal_get_path($css);
   

4. The above applies only when you try to set it inside page.tpl.php or $hook->page in _phptemplate_variables().
5. Adding drupal_add_css() outside of $hook->page works fine inside _phptemplate_variables(). It will get called multiple times for each hook iteration but the function adds the style only once..

Correction for #5. The function would just overwrite the same style so it's not a good idea.

@hass: if you need this kind of functionality, provide a patch in a new issue.

Ah, sorry, I didn't see the link.

Changed the component to reflect the new component categorization. See http://drupal.org/node/301443
-dokumori