url() creates wrong URLs

Sorry, this is partly wrong. if i remove url() i get the URL

/drupal-5.0-beta1/modules/mymodule/js/myscript.js

as you wrote. But this is *not* the menu path i registered with the module. it must be:

/drupal-5.0-beta1/index.php?q=modules/mymodule/js/myscript.js

let's say - this is not a real static JS file. it's a PHP include, sending a special JS MIME type and returns dynamic JS code...

and only if i'm using CleanURLs i get

/drupal-5.0-beta1/modules/mymodule/js/myscript.js

what is finaly correct, too. but all this requires URL() to work properly and this is critical bug.

HEY - this is NOT FIXED!

This one has worked in Drupal 4.7.x very well - why is this changed for 5.0 and not on the list of changes? This must be a bug!

Asside i think you haven't understand what i'm doing.

1. i created a module.
2. this module requires to add some JS code to every page
3. this module is a frontend to the JS file.
4. this module saves settings required in the JS file in the drupal database
5. every theme have different settings and therefor the JS is dynamic
6. if someone requests the path /drupal-5.0-beta1/index.php?q=modules/mymodule/js/myscript.js he gets a dynamicaly build JS file with special variables declared for this special theme and page and the correct mime type.

Please, tell my how this can be done in a different way. And let me say some other modules are using this variant, too:

Example:

  if ($may_cache) {
    $items[] = array(
      'path' => (drupal_get_path('module','mymodule').'/js/myscript.js'),
      'access' => true,
      'callback' => 'mymodule_get_javascript',
      'access' => user_access('access mymodule'),
      'type' => MENU_CALLBACK,
      );
   }

  return $items;
}

function mymodule_get_javascript () {
  
  // send JS headers
  drupal_set_header("Content-type: text/javascript; charset=utf-8");
  
  $output.= "var myvar1 = ".round(variable_get(mymodule_setting_myvar1, 54),0).";\n";
  
  ...more JS code will be added here...
   
  print $output;
  
}

so, this ends up the URL() function is doing something wrong or drupal_get_path('module','mymodule') makes no sense.

Regards
Alex

I think i understand about this possible performance issue, but this is not the problem with caching enabled. Asside this DB requests are only for my module variables i must get from variable table. i don't see the real problem and other moduls do the same. You won't tell me it is not allowed to use drupal_set_header and some logics behind - isn't it? simply search for header, drupal_set_header or drupal_get_header any you will find a bunch of modules using it for dynamicaly create JS, XML, and so on (examples: devel, gsitemap, urllist, quicktags, etc) and so on. Performance is a reasonable point, but caching should be in place and this is not forgotten.

drupal_set_html_head() won't be a good idea, while it is bad SEO practice to add JS code to a page head. i know it is technical correct, but for search engines this is somewhat a very big bad idea... however some developers are doing wrong without the SEO's knowledge. It is recomended to move JS code to external JS files for XHTML.

drupal_add_js() requires to have static code dupliacted. this is not good and i don't like to do this. Additional i must write a frontend for writing JS files to disk, what is not required and awful... asside of the filesystem permission problems i will get with such a module. if it's in private store i will have a drupal run to get out the file, too. if the file is saved in modules dir everone run in permission troubles.

You haven't answered my question about - why it works in Drupal 4.7.x . I reactivated the bug, while this has worked in 4.7 and is now broken! And it should be fixed for compatibility with IIS and Apache, regarding cleanurl's and standard URLs. This is the thing we need the helpfull function url() for and i'm sure others will run into this problem, too. My dynamic JS files are only a small example...

i thought more about this issue.

if i have a iframe inserted to a page - with a module, let say for example for advertisements, and this one calls for a PHP file inside my modules directory, i have the same issue... therefor this is not limited to JS, XML.

if you think url() is working correctly, please give me a hint how to solve the problems i described.

• why do i need to have an iframe linked outside my page? it can be linked to my modules directory and calling an additional file. for e.g. to add AD's changing with every request. Only my server knows what AD should be displayed. iframes are not external URLs in general.
• how is is possibly to add an URL linking to a file located inside my modules directory (e.g. file download). As i told the JS was *only* an easy and good example of many possibly situations where i need the correct URL (cleanurl and if not activated normal urls).
• how is it possible to add "?q=gsitemap" Google Sitemap in XML or "?q=urllist.txt" Yahoo TXT Sitemap with a correct base path to HTML sourcecode? (cleanurl and non clean)
• in General - how to add a file URL to HTML for other mimetypes if it is not possibly to add them inside page content like JS and CSS what is a no go in XHTML and SEO.