Closed (fixed)
Project:
Feeds
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Oct 2010 at 17:24 UTC
Updated:
15 Oct 2010 at 18:50 UTC
Jump to comment: Most recent file
Right now fetchers and parsers are supposed to set total and progress, later a progress floating point number between 0.0 and 1.0 is computed on the FeedsSource level.
This means the assumption is that a natural number total and progress are managed at $state->total and $state->progress by plugins.
We should consolidate this into a single float 'progress' that is set by plugins with a helper function. Thus we consolidate progress tracking into a single floating point.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 928836-2_set_progress.patch | 8.85 KB | alex_b |
| #1 | 928836-1_set_progress.patch | 8.77 KB | alex_b |
Comments
Comment #1
alex_b commentedTested manually, running simple tests right now. Will commit shortly.
Comment #2
alex_b commented- progress needs to be FEEDS_BATCH_COMPLETE by default.
- we're still using FEEDS_BATCH_ACTIVE
Comment #3
alex_b commentedCommitted.
http://drupal.org/cvs?commit=430626