When the file fetcher's setting 'supply path directly' setting is selected, the file upload is still shown. WIth recent changes to the fetcher where Feeds uses the File API to track files that are uploaded, but don't track files that are merely supplied by path this gets rather confusing. For instance, files that are uploaded get deleted with the source. Files that supplied by path reference are never touched.

Let's hide the file upload when the 'supply path directly' feature is chosen. Also cleans up the form tremendously.

CommentFileSizeAuthor
#1 930018-1_hide_upload.patch4.4 KBalex_b
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alex_b’s picture

Status: Active » Needs review
FileSize
4.4 KB

Diff looks large, but essentially adds a if/else statement testing for the 'direct' option in the upload form.

Tests are passing, will commit shortly.

alex_b’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.