Download & Extend
Project » Issues

Do not merge installer.po into merged PO file

Posted by Gábor Hojtsy on November 5, 2006 at 10:04pm
Project:Project
Version:4.7.x-1.x-dev
Component:Releases
Category:task
Priority:normal
Assigned:dww
Status:closed (fixed)

Issue Summary

The translation packaging script should not merge an installer.po file into the language PO file for download, since installer.po files are to be used on the file system so that the installer can pick them up for language specific wizard presentation.

Login or register to post comments

Comments

#1

Posted by dww on November 7, 2006 at 9:19pm
Assigned to:Anonymous» dww
Status:active» needs review

i think this is all we need, right? i haven't seen any installer.po files in the repo, so i can't really test this, but it seems to solve the reported problem. namely:

  • the installer.po isn't merged into the monolithic [lang].po file
  • the installer.po *is* still included in the final tarball

that's what we're aiming for, no? anyone translation-aware care to comment/review?

thanks,
-derek

AttachmentSizeStatusTest resultOperations
package_release_nodes_no_installer_po.patch.txt1.12 KBIgnored: Check issue status.NoneNone

#2

Posted by Gábor Hojtsy on November 7, 2006 at 11:34pm

Yes, this is what we are aiming for exactly.

#3

Posted by dww on November 8, 2006 at 12:34am
Status:needs review» fixed

Kjartan saw nothing wrong with this. if it's what you want (and you're definitely the expert in such matters), we're happy to provide it. ;) committed to the DRUPAL-4-7--2 branch as revision 1.1.2.6 and now updated on s.d.o. if you want to try adding an installer.po file to your translation's directory in the s.d.o cvs repo (see http://drupal.org/node/90436#scratch-repo for more info) and see if things are being packaged how you'd expect, that'd be great. just re-open this issue if you find any problems. otherwise, i'll assume all is well.

thanks,
-derek

#4

Posted by Anonymous on November 22, 2006 at 12:47am
Status:fixed» closed (fixed)