Posted by hunmonk on November 6, 2006 at 3:24am
3 followers
| Project: | CVS integration |
| Version: | 4.7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | dww |
| Status: | closed (fixed) |
Issue Summary
when you try to create a release node without any available branches or tags, you get a nice error message which instructs you to create some tags, then click the 'Retry' button. following those instructions gets you to a 'CVS identifier field is required.' error when you click the button.
this is a FAPI problem, i think, where the form validation is fooled, because the form has been submitted without the required field, but built with it for the new page. maybe try a #multistep? not sure if that will fix the problem or not.
Comments
#1
yeah, this is a minor pain in the ass. i just didn't care enough about it to spend any more time on that gnarly FAPI N-page crap. ;) i don't want to re-write all the FAPI stuff to be #multistep compliant. i think an even better solution would be to just have the "retry" button completely clear $_POST, as if you landed on the form for the first time again. basically, we should just hide that button completely (technically it's the "preview" button from the node form), and add a "retry" link, instead of a form button. then, it'd all work fine.
anyway, this is way less important to me than everything else on http://drupal.org/node/90436#future-work but i just added this issue there, in case someone else is inspired to roll a patch for it. (hint, hint). ;)
thanks,
-derek
#2
since it was so easy... ;)
#3
#4
committed to DRUPAL-4-7--2 branch as revision 1.106.2.19.2.19.
updated on scratch.d.o.
#5