Allow attachments to be added by contents

I think this should be done by _mimemail_file(). We can add a $content parameter then it will do the rest. Would you mind modify your patch in that way?

I looked into rewriting this patch as requested by sgabe, but with all due respect it seems to me that it makes more sense the way it was originally written by clydefrog. Can you explain the reasoning behind wanting this to be done by _mimemail_file()? If the attachment is a string rather than a file then there isn't really any reason to call _mimemail_file, and as far as I can tell it would take more code to include it there.

For my implementation, the one change I made from the submitted patch was:

    if(!isset($a->list) || $a->list) {
-      if (isset($a->filepath)) {
+      if (!isset($a->contents)) {
        _mimemail_file($a->filepath, $a->filename, $a->filemime, 'attachment');
        $parts = array_merge($parts, _mimemail_file());

Quick testing -- you need the elseif ($content) clause before the elseif ($url) clause. For my use case, I need to pass a path to mimemail -- I am attaching a PDF created by a view passed through the print_pdf module, and the path provides the view that is being converted.

The attached patch works for me.

I think we can do a bit better than that.

@arvana: Why would you need the path? You just need to set the "filecontent". I'm doing something like this and it works fine. Of course this is a dirty hack for me to be able to test this patch.

$attachments = array(
  array(
    'filecontent' => _print_pdf_tcpdf($print, $html, $pdf_filename), // Returns the document as string.
    'filename' => $pdf_filename,
    'filemime' => 'application/pdf'
  )
);

Thanks to both of you for giving this issue your kind attention.

@sgabe: In my use case, I am attaching a PDF that is converted from a View. So I'm using print_pdf both to create the $html and the PDF attachment. I am definitely not a real programmer though, especially in Drupal, so I'd be happy to hear if there's a better way to do what I want. Here's my code -- 'ticket' is the View of the content I'm attaching:

<?php
      $path = 'ticket/' . $node->nid;
      $attachments[$counter] = array(
        'contents' => print_pdf_controller($path),
        'filemime' => 'application/pdf',
        'filename' => 'ticket-' . $order->order_id . '.pdf',
      );
?>

That's okay, what I don't understand is why the patch in #7 would not work for you?

It doesn't work because I am passing both a $url and $content through _mimemail_file -- it may not be the most common use case, but anyone who wants to attach a PDF created by the print module is going to have to do that. So for this use, it needs to check for $content before it does other things with $url. :)

I am passing both a $url and $content through _mimemail_file

I still don't understand why would you need to pass the $url to _mimemail_file() when the attachment is created by it's content.? :)

Furthermore, in #8 you didn't set the filepath for the attachment, hence the $url will be NULL in _mimemail_file(). So the patch in #7 should work for you.

Haha well it DOESN'T work, whereas if I put the $content clause before the $url clause it does. Maybe my diagnosis of WHY it doesn't work is wrong. I will investigate further.

(subscribe)
I'm interested in this... my module needs to send generated PDFs (using TCPDF) from a rule

It looks ready to me, I would like to commit some issues next week. This one included, if arvana can't tell us why would this not work for him.

Sorry it took me a while to get back here -- I finally figured out the error. It was my fault; I missed the variable name-change from $attachments[x]['contents'] to $attachments[x]['filecontent'].

So this gets the go-ahead from me to commit. :)

Thanks for your feedback, arvana. I guess this can be marked as RTBC.

Committed to 6.x-1.x, but needs to be ported to 7.x.

Now committed to both branches.