properly handle extra identifiers in cvs tags for releases

dww - November 6, 2006 - 22:59
Project:CVS integration
Version:4.7.x-1.x-dev
Component:Project releases
Category:bug report
Priority:normal
Assigned:dww
Status:closed
Description

as described in http://drupal.org/node/90436#comment-169221 (point #3), we're not properly handling CVS tags that define extra identifiers, e.g. "DRUPAL-5--1-0-BETA-1". the solution is easy: in cvs_get_version_from_tag(), when we're using explode() on the part of the tag name after the '--', we just want an argument so that we explode into at most 3 things: (major, patch, extra). then, if extra contains an '-' chars, they're all still included in extra (and our handy _cvs_get_extra() method will properly format it for us). we already do this trick for core, we just need to do it for contrib, too.

AttachmentSize
cvs_local_tags_with_extra.patch.txt858 bytes

#1

dww - November 6, 2006 - 23:08

natrak agreed this is RTBC, so i committed to DRUPAL-4-7--2 branch as revision 1.1.2.11.

#2

dww - November 6, 2006 - 23:30
Status:reviewed & tested by the community» fixed

#3

Anonymous - November 20, 2006 - 23:46
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.