Hi,
when i disable PubSubHubbub service, in Feed Importer settings, the feeds_push_subscriptions is not empty but it keeps pub subscription topics.

I think that if I disable PubSubHubbub service the feeds_push_subscriptions table should be empty.

When I enable newly PubSubHubbub service the feeds_push_subscriptions table will be re-filled.

jscm
Milan (Italy)

CommentFileSizeAuthor
#4 933306-4_push_check_exists.patch685 bytesalex_b

Comments

alex_b’s picture

alex_b commented
Status: Active » Closed (won't fix)

The remaining subscriptions in the table don't hurt you. What matters is that they are deleted when the source is deleted.

As long as we don't find a concrete bug stemming from the subscription records sticking around, this is a won't fix.

jscm’s picture

jscm commented

Ok, I understand...

BUT...
this is in relation with argument in this discussion http://drupal.org/node/929448 and it hurts me.

alex_b’s picture

alex_b commented
Version: 6.x-1.0-beta9 » 6.x-1.x-dev
Status: Closed (won't fix) » Active
Issue tags: +PubSubHubbub

You're right, there is a bug. I reviewed the code and found the problem.

FeedsHTTPFetcher::request(): PuSH subscriptions are accepted without checking whether PuSH is enabled.

alex_b’s picture

alex_b commented
Priority: Normal » Critical
Status: Active » Reviewed & tested by the community
StatusFileSize
new 933306-4_push_check_exists.patch685 bytes

This patch at least fixes an obvious bug, there may be more we can do to respond to all PuSH requests according to spec http://pubsubhubbub.googlecode.com/svn/trunk/pubsubhubbub-core-0.3.html#...

alex_b’s picture

alex_b commented
Title: PubSubHubbub disabled but feeds_push_subscriptions table is not empty » Feeds creates subscriptions for not existing importers
alex_b’s picture

alex_b commented
Version: 6.x-1.x-dev » 7.x-2.x-dev

Committed to 6.

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x.

Status: Fixed » Closed (fixed)
Issue tags: -PubSubHubbub

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +PubSubHubbub

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.