Hi,
when i disable PubSubHubbub service, in Feed Importer settings, the feeds_push_subscriptions is not empty but it keeps pub subscription topics.
I think that if I disable PubSubHubbub service the feeds_push_subscriptions table should be empty.
When I enable newly PubSubHubbub service the feeds_push_subscriptions table will be re-filled.
jscm
Milan (Italy)
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 933306-4_push_check_exists.patch | 685 bytes | alex_b |
Comments
Comment #1
alex_b commentedThe remaining subscriptions in the table don't hurt you. What matters is that they are deleted when the source is deleted.
As long as we don't find a concrete bug stemming from the subscription records sticking around, this is a won't fix.
Comment #2
jscm commentedOk, I understand...
BUT...
this is in relation with argument in this discussion http://drupal.org/node/929448 and it hurts me.
Comment #3
alex_b commentedYou're right, there is a bug. I reviewed the code and found the problem.
FeedsHTTPFetcher::request(): PuSH subscriptions are accepted without checking whether PuSH is enabled.
Comment #4
alex_b commentedThis patch at least fixes an obvious bug, there may be more we can do to respond to all PuSH requests according to spec http://pubsubhubbub.googlecode.com/svn/trunk/pubsubhubbub-core-0.3.html#...
Comment #5
alex_b commentedComment #6
alex_b commentedCommitted to 6.
Comment #7
alex_b commentedCommitted to 7.x.