Patch fixes 3 calls to t()
moves default cache dir to files folder, and then makes it if it doesn't exist.
Means end users don't need to ssh into their server etc to get this module going.

Patch is against CVS HEAD

CommentFileSizeAuthor
#4 gcal_events_0.patch1.94 KBShiny
#1 gcal_events.patch1.94 KBShiny
gcal_events.patch1.94 KBShiny

Comments

Shiny’s picture

Shiny commented
StatusFileSize
new gcal_events.patch1.94 KB

fixed typo in directory name in this patch

andypanix’s picture

andypanix commented

Hi, sorry for that, but I think that the typo is styll there ;-)

-define('GCAL_EVENTS_DEFAULT_CACHE', drupal_get_path('module', 'gcal_events') ."/cache");
+define('GCAL_EVENTS_DEFAULT_CACHE', file_directory_path() . '.gcal_events/cache');

For better internationalization support, what about to use the Drupal "format_date" function, against php date function?

Shiny’s picture

Shiny commented
StatusFileSize
new gcal_events_0.patch1.94 KB

you're right - it's still there.
fixed now.

polishyourimage’s picture

polishyourimage commented

has this been included in the latest stable release? I have to move the cache directory.

jdwfly’s picture

jdwfly commented
Status: Needs review » Fixed

Just committed this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.