Download & Extend

module browse page download links broken when filtering by [all]

Project:Project
Version:4.7.x-1.x-dev
Component:Releases
Category:bug report
Priority:critical
Assigned:dww
Status:closed (fixed)

Issue Summary

http://scratch.drupal.org/project/Modules
browse by name
Filter by Drupal Core compatibility: [all]
hit 'go'.

the first few entries seem fine, but if you hover over the "Download" link under "Acidfree" (for example), you get a link to http://scratch.drupal.org/files/projects/accents-HEAD.tar.gz not http://scratch.drupal.org/files/projects/acidfree-HEAD.tar.gz (or better yet, http://scratch.drupal.org/files/projects/acidfree-4.7.x-1.x-dev.tar.gz, since that's the default version selected for acidfree) as you'd expect. a bunch of other modules have this problem. i'm pretty sure this has something to do with trying to select the right download link by taking the per-project "default version" stuff into account...

this absolutely must be fixed before the system goes live. i'll see if i can roll a patch for this, though the real expert in these matters is nedjo, but he's not around on IRC at the moment...

Comments

#1

Status:active» needs review

When filtering by [all] this patch will make sure to pick up the default release for each project.

AttachmentSizeStatusTest resultOperations
project-browse-page.patch1.56 KBIgnored: Check issue status.NoneNone

#2

Status:needs review» reviewed & tested by the community

weird, Kjartan's patch didn't apply for me at all. here's another version of the same code without the DOS line-breaks, and it seems to be fine. the SQL looks good, and it tests out fine on my site (Kjartan and i discussed this patch extensively in IRC). i'm going to commit this to DRUPAL-4-7--2.

AttachmentSizeStatusTest resultOperations
project-browse-page.patch_1.txt1.58 KBIgnored: Check issue status.NoneNone

#3

Status:reviewed & tested by the community» fixed

commited to DRUPAL-4-7--2 branch as revision 1.239.2.13.2.10.

#4

and updated on scratch.d.o... (thanks, kjartan)

#5

Status:fixed» closed (fixed)
nobody click here