Closed (fixed)
Project:
Decisions
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
7 Nov 2006 at 21:50 UTC
Updated:
23 Nov 2006 at 19:30 UTC
Jump to comment: Most recent file
The decisions.module contains a bunch of mode-specific code, like code referring to algorithms for instance. We need to move that code out of the core and have the various modes implement them with hooks.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | decisions-cvs_tatien_93520_7.patch.txt | 4.19 KB | anarcat |
| #14 | decisions-cvs_tatien_93520_4b.patch | 1.03 KB | tatien |
| #9 | decisions-cvs_tatien_93520_8.patch | 1.32 KB | tatien |
| #8 | decisions-cvs_tatien_93520_7.patch | 4.23 KB | tatien |
| #7 | decisions-cvs_tatien_93520_6.patch | 1.24 KB | tatien |
Comments
Comment #1
tatien commentedComment #2
tatien commentedThis first patch resolves the problem wrt algorithms.
Comment #3
tatien commentedThis is some code cleanup to continue on. It basically removes the _decisions_modes_list() function.
Comment #4
tatien commentedThis patch actually completes the job made in last patch, in a cleaner way.
Comment #5
tatien commentedModified the hook_node_info to automatically build according to the different modes.
Comment #6
tatien commentedModified the decisions_help($section) method.
Comment #7
tatien commentedPatched the decisions_menu() function.
Comment #8
tatien commentedPatched decisions_tab_votes().
Comment #9
tatien commentedPatched the function decisions_insert($node).
Comment #10
tatien commentedNothing else to do from what I can see wrt this issue. Waiting for review of patches 1-8.
Comment #11
anarcat commentedi'll look into this.
Comment #12
anarcat commentedRe: patch #_3 and #_4, do not send diff in another format than -u, otherwise it can mis-apply. Second, merge relevant patches instead of packing them on top of another.
Comment #13
anarcat commentedpatches 1 to 3 were applied and committed. Patch 4 has a problem, it does not define the mode_node_info() hooks and will therefore need to be reworked. I will not apply the other patches until I have that piece.
Also, when patches are ready to committed, mark them as "ready to be committed" :)
Comment #14
tatien commentedThis patch fixes the problem wrt mode_node_info() from patch 4.
Comment #15
anarcat commentedCool, I've applied #4, moving on the 5-8.
Comment #16
anarcat commentedI've reworked the patch #5 to name the hooks decisions_format_votes_(), but it doesn't apply anymore, I don't know why..
Comment #17
anarcat commentedThat was of course the patch #7 i was talking about here, the patch #5 and 6 have been applied to CVS.
Comment #18
anarcat commentedOkay, we've figured out the #7, and all patches have now been applied. Considering this issue as resolved, as the last string occurrence of "poll" remaining in the module is in a weird div class. :)
Comment #19
(not verified) commented