I activated the drupal locale module and imported the italian po file but date.module dates aren't translated. How can this be done? Do I have to translate every string manually from drupal interface?

CommentFileSizeAuthor
#17 date.inc__0.txt74.44 KBkarens
#16 date.inc_.txt73.68 KBkarens

Comments

dodorama’s picture

dodorama commented

I tried to extract a pot file from date.module files but there are not strings to translate months, weeks, days.
So I think this must be a kind of bug(or missing feature) since date releated to post submission are translated.

P.S.
while extracting the pot files with extractor.php I had this errors:

Invalid marker content in date.inc:743
* t($label)

Invalid marker content in date.inc:1325
* t($day_short[$array['weekday']])

Invalid marker content in date.inc:1327
* t($array['weekday'])

Invalid marker content in date.inc:1333
* t($array['month'])

Invalid marker content in date.inc:1335
* t($month_short[$array['month']])

Invalid marker content in date_views.inc:98
* t('This filter allows events to be filtered by their date. Enter dates in the format: '.$format.'. Enter \'now\' to use the current time. You may enter a delta (in seconds) to the option that will be added to the time; this is most useful when combined with now. If you have the jscalendar module from jstools installed, you can use a popup date picker here.')
dodorama’s picture

dodorama commented
Category: feature » bug

I mark this as a bug since, I guess, there must be something wrong on those strings I mention above.

dodorama’s picture

dodorama commented

This must be the problem.
I try to solve it by myself then I'll come back here asking for help :)

dodorama’s picture

dodorama commented

I haven't been able to solve this.
Any help?

karens’s picture

karens commented

I think maybe the translate function won't work on variables like this. I'm no expert on how that function works, though. If anyone knows the best way to set this up I'll be glad to make the changes.

dodorama’s picture

dodorama commented

is it possible to use the translate function while creating the array?

dodorama’s picture

dodorama commented

digging to the code I haven't been able to understand how to solve this;
but I found another way to have dates translated. I used the translate (t) function in my template (node-content_mycontent.tpl.php) like this (just in case someone want to use this trick):

<?php $calendardate = explode(' ', content_format('field_data', $field_data[0], 'default')); ?>
            <div class="calendar-info">
              <h4 class="calendar-date">
                <?php print t($calendardate[0])?><br />
                <span class="calendar-number"><?php print $calendardate[1]?></span><br />
                <?php print t($calendardate[2])?>
              </h4>
karens’s picture

karens commented
Status: Active » Fixed

Should be fixed now.

dodorama’s picture

dodorama commented
Status: Fixed » Active

The strings to translate months and days are now avaiable for translation but once translated only the strings on the input form are translated (not the output in the node view).

P.S. there's still an error when extracting the po file from date_views.inc :

Invalid marker content in date_views.inc:98
* t('This filter allows events to be filtered by their date. Enter dates in the format: '.$format.'. Enter \'now\' to use the current time. You may enter a delta (in seconds) to the option that will be added to the time; this is most useful when combined with now. If you have the jscalendar module from jstools installed, you can use a popup date picker here.')
karens’s picture

karens commented

fixed the last translation error in the latest commit

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

The day texts still don't get updated here...
I installed the 4.7-dev version, but the fields keep displaying "Mon, Tue, Wed", where i want these to be local.
When editing the field, the dropdown boxes also show the english names of the days, even though my locale is set to Dutch as standard setting.

What can be the cause why this isn't working yet?

vito_swat’s picture

vito_swat commented

I have the same problem with 5.x version. Dates in the output aren't translated. In my opinion problem is in date.inc in function date_show_date which is responsible for the output string. I made following changes in the code, using default drupal format_date function:

function date_show_date($date, $format_string, $type = 'local', $zone_display = '') {

  if ($zone_display) {
    $append = date_append_zone($date, $zone_display);
  }

  // using gmdate so php won't try to adjust value for server timezone
  // needed because date object has already made necessary timezone adjustments
  if ($type == 'db' || (!$date->local->timestamp && $date->local->timestamp != 0)) {
    //removed by vito: return date_gmdate($format_string, date_fuzzy_stamp($date->db)) . $append;
    return format_date(date_fuzzy_stamp($date->db), 'custom', $format_string, NULL) . $append;
  } elseif ($date->local->timestamp || $date->local->timestamp == 0) {
    //removed by vito: return date_gmdate($format_string, date_fuzzy_stamp($date->local)) . $append;
    return format_date(date_fuzzy_stamp($date->local), 'custom', $format_string, NULL) . $append;
  }
}

For my case (I only need month and year) it seems to work. Gimme a feedback is it working for you.

dodorama’s picture

dodorama commented
Priority: Normal » Critical
karens’s picture

karens commented

I'm going to try to work on this today. The last suggestion will break many things, so don't use that.

This thread is getting hard to follow. Can you summarize exactly where you are now getting values that are not translated in forms, on the node display and wherever else you see them.

dodorama’s picture

dodorama commented

Date strings aren't translated on node display.
Date strings are translated on the input form.

karens’s picture

karens commented
StatusFileSize
new date.inc_.txt73.68 KB

The problem is that those dates are coming from the php date format function so they don't behave the way translation normally works. I'm posting a file for you to try as a replacement for the date.inc file to see if it works for you. I don't want to commit anything until I see if this approach will work.

This is the 4.7 version, since that's the way this issue is marked.

I had to rename the file to date.inc.txt to get it to upload, but change the name back.

karens’s picture

karens commented
StatusFileSize
new date.inc__0.txt74.44 KB

And here's a file with a different approach. Same thing, use this as a replacement to date.inc and rename it.

Let me know which works better.

dodorama’s picture

dodorama commented

Is this for drupal 5?
both patches cause a fatal error on 5:
Call to undefined function: module_exist() in /home/yuppiefl/public_html/cms/sites/all/modules/date/date.inc on line 41
I'll try with 4.7

dodorama’s picture

dodorama commented

the second patch works great!

karens’s picture

karens commented

No, as noted in #16 this is the 4.7 version since this issue is marked as a 4.7 issue.

Anyway, I don't think the first method is going to work right, so the second is the one I'm going to try. It doesn't seem to break anything in English and at least theoretically should work for other languages.

Committed in all branches.

karens’s picture

karens commented
Status: Active » Fixed

Oops, cross-posted, but that confirms what I thought.

peddecke’s picture

peddecke commented

Can you make a patch for 5.x too? Thanks!

karens’s picture

karens commented

This was committed to all branches, no patch needed. You just need the latest nightly snapshot (-dev) release.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)