Support for Postgres [#935470]

A bug in quiz.admin.inc

In line: 1940 $filter['group'] .= " GROUP BY qnrs.uid"; should be enclosed in if-mysql check. It's not at the moment, hence
there's an invalid syntax GROUP BY qnrs.uid"; GROUP BY qnrs.uid, u.uid, u.name, qnrs.result_id, qnrs.score, qnrs.is_evaluated, qnrs.time_start, qnrs.time_end, qnp.pass_rate"; produced in PostgreSQL.

Dirty fix (just commented non-postgres stuff):

//$filter['group'] .= " GROUP BY qnrs.uid";
    if ($db_type == 'pgsql') {
      $filter['group'] .= " GROUP BY qnrs.uid, u.uid, u.name, qnrs.result_id, qnrs.score, qnrs.is_evaluated, qnrs.time_start, qnrs.time_end, qnp.pass_rate";
    }

Comments

Comment #1

sebzur commented 8 October 2010 at 02:10

And another thing, I had to add some explicit type casting, to have no error wher quering for some quize statistics: (quiz.module:2159-2166)

$sql = "UPDATE {quiz_node_properties} qnp
          SET max_score = cast (max_score_for_random as bigint) * CAST (number_of_random_questions as bigint)+ cast((
            SELECT SUM(max_score)
            FROM {quiz_node_relationship} qnr
            WHERE qnr.question_status = " . QUESTION_ALWAYS . "
            AND parent_vid = qnp.vid
          ) as bigint)

Comment #2

sebzur commented 8 October 2010 at 02:39

And another one issue. Quiz complains when submited and sent via e-mail to authror:

    * warning: pg_query() [function.pg-query]: Query failed: ERROR: argument of AND must be type boolean, not type int_unsigned in ...PATH.../includes/database.pgsql.inc on line 139.
    * user warning: query: SELECT CEIL((time_end - time_start)/60) FROM quiz_node_results WHERE result_id = '31' AND time_end in ...PATH.../sites/all/modules/quiz/quiz.module on line 2068.

fixed with explicit casting, line 2068 in quiz.module:

'!minutes' => db_result(db_query("SELECT CEIL((time_end - time_start)/60) FROM {quiz_node_results} WHERE result_id = '%d' AND cast(time_end as boolean)"

Comment #3

falcon commented 13 November 2010 at 17:58

Status:

Active

» Postponed

Marking this one as postponed. If we get a patch in here someone might review and commit it, but I don't think the current maintainers have the time to add postgres support :/

Comment #4

sebzur commented 16 November 2010 at 18:25

OK, what can I do to help? I need the Quiz dramatically - I'm patching it version by version on my own - (I've even tried to port my DB form Postgres to MySQL, but it's quite complicated, though)...

So - shall I attach a patch file here? There are only minor changes, so It would be great to apply it and have the issue closed. I could even monitor Postgres compliance for Quiz.