Are there any plans to upgrade this to D7? I couldn't find any information about this in the issue queue and there were no branches in CVS... Although sometimes I miss things that are right in front of my face...

Anyway, Just thought I would ask. I've actually been working on an upgrade as it is, so if no one else is working on it, I could post a patch when I am done. This would be for the Stock Module as well as the Stock API... Although I guess I would post the Stock Module patch in it's own issue queue

Thanks!

CommentFileSizeAuthor
#15 stockapi_D7_port.patch52.89 KBbrianV
#12 stockapi.zip23.06 KBdrclaw
#6 stockapi_d7_upgrade_v2.patch13.16 KBdrclaw
#5 stockapi_convert_to_d7.patch13.16 KBdrclaw

Comments

nsummy’s picture

nsummy commented

I'm not a developer but I would definitely be interested in having this ported over to 7. Right now this module is kind of a sticking point in upgrading to D7

drclaw’s picture

drclaw commented

I actually have a version of this one upgraded to D7. I'll post a patch for you as soon as I can.

yugongtian’s picture

yugongtian commented

waiting~

drclaw’s picture

drclaw commented

Here's the patch I've been procrastinating on. Sorry if anyone was waiting for it!

Unfortunately I've only tested it on D7 beta1 and beta2. I don't think anything's changed that will affect these changes, but I haven't had a chance to test it on a proper Drupal 7 v1.0 yet.

Place the patch in the root of the the stockapi module folder (e.g. stockapi/stockapi_convert_to_d7.patch) and, from the command line, use the command patch < stockapi_convert_to_d7.patch to patch it.

The stock module patch, if anyone needs it, is in the stock module issue queue: #1038906: Upgrade to D7 Patch

drclaw’s picture

drclaw commented
StatusFileSize
new stockapi_convert_to_d7.patch13.16 KB

It helps if you upload the file...

drclaw’s picture

drclaw commented
StatusFileSize
new stockapi_d7_upgrade_v2.patch13.16 KB

Holy moly, huge rookie mistake! Don't even touch that last one... had the diffs backwards!

drclaw’s picture

drclaw commented
Status: Active » Needs review
SeanBannister’s picture

SeanBannister commented

sub

beauz’s picture

beauz commented

subscribing

Kman2123’s picture

Kman2123 commented

sub

sea4’s picture

sea4 commented

Hi, Can you post a full copy of the patched module. i don't have root or ssh access.

drclaw’s picture

drclaw commented
StatusFileSize
new stockapi.zip23.06 KB

Here you are. Enjoy!

Kman2123’s picture

Kman2123 commented

Do you just copy this into modules folder on server?

drclaw’s picture

drclaw commented

You should put it in sites/all/modules. See this http://drupal.org/documentation/install/modules-themes/modules-7 to learn more about installing modules.

brianV’s picture

brianV commented
Version: 6.x-1.x-dev » master
StatusFileSize
new stockapi_D7_port.patch52.89 KB

drclaw:

I am not sure what you are basing your port off of, but the diff doesn't apply to the current 6.x master branch in the current git. In fact, it looks like it was done off a copy from prior to the big performance enhancements committed on 2008-07-21.

I've gone ahead and done a port myself based on the the latest git version for D6. This applies to the 'master' branch in git. I'll also attempt to get commit access for this module, so I can create a D7 release branch.

AFAIK, it's working correctly, except the _stockapi_fix_floats() function needs a re-think as it discards some data it doesn't necessarily need to.

Note: The D7 port can also be retrieved from my sandbox at http://drupal.org/sandbox/brianV/1197802

brianV’s picture

brianV commented

A new D7 branch has been created. A dev release should be rolled by tomorrow morning.

I am closing this thread; bugs against the new branch can be filed separately.

brianV’s picture

brianV commented
Status: Needs review » Fixed
drclaw’s picture

drclaw commented

@brianV

I built the patch in October 2010 off whatever the dev release was at that time for Drupal 6. It should have worked. I remember testing it. That's why I posted it twice, because the first one didn't work... =/

Thanks for making the d7 release though! Glad to see things are happening. =)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

7wonders’s picture

7wonders commented
Category: task » bug
Status: Closed (fixed) » Active

I think the error I have reported here on stock module:

http://drupal.org/node/1198132

Is due to stockapi module not functioning on d7. Let me know if there is anything I can do to help debug.

brianV’s picture

brianV commented

Well, I can guarantee you that the code does indeed work as we have the StockAPI running on a production site.

Furthermore, please file any issues in their own bugs rather than re-opening this old one.

7wonders’s picture

7wonders commented
Status: Active » Fixed

Sorry, my bad. Will file a new bug report now.

brianV’s picture

brianV commented
Status: Fixed » Closed (fixed)