Closed (fixed)
Project:
Revisioning
Version:
6.x-3.11
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Oct 2010 at 10:38 UTC
Updated:
18 Dec 2011 at 02:34 UTC
Jump to comment: Most recent file
Comments
Comment #1
rdeboerNot a bad idea, Pedro!
I would prefer to check permissions before rendering an "Edit" link though.
Otherwise the user may get an "Access denied" when they click the link.
If they don't have permission to edit the file, ideally the link should not appear at all.
Rik
Comment #2
pcambraYeah, I though about that, but should then the operations column be hidden as well if there is no operation with permissions, right?
As far as I have understood, the permission for all this operations is only "edit revisions", would make sense to create additional permissions like delete or revert? would make sense to create one permission for each content type then?
Comment #3
pcambraI'm attaching a new patch including Publish, Edit, Revert and Delete links.
I've called _revisioning_node_revision_access for checking if the user has permissions to execute the action prior to display the link, but I'm getting only the Edit action besides I'm superuser and I've the privileges to all these actions in the permisions page. Maybe this should be invoked via user_access instead?
Also I'm including a css folder with a css and one tango (GPL) image for each action.
Please, let me know what you think
Comment #4
rdeboerCan be done now using the Module Grants View submodule (part of Module Grants package download). It allows you to add Edit and Delete links to your View that honour the permissions.
Comment #5
rdeboer