The attached patch turns off the morechoices checkbox, but it should do that only if the user agent supports javascript. A good way is to disable the box *using* javascript.

CommentFileSizeAuthor
disable_morechoices.patch.txt1.08 KBanarcat

Comments

anders.fajerson’s picture

anders.fajerson commented

I don't follow. "get rid of the "add more choices" checkbox only if javascript is disabled" - you mean the the opposit; not to show it when javascript is enabled, right?

And what is this patch for, just an example on how it shouldn't be done? Just use jQuery .hide() and hide the morechoise option: $("#morechoices").hide()

anarcat’s picture

anarcat commented

Right... "enabled" was what I meant... :) I just scratched this here quickly to not forget it...

The patch is indeed an example on "how not to do it". jQuery is probably the way to go, but I'm not very familiar with it, so I'll take your word for it...

anarcat’s picture

anarcat commented
Title: get rid of the "add more choices" checkbox only if javascript is disabled » get rid of the "add more choices" checkbox if javascript is enabled
anders.fajerson’s picture

anders.fajerson commented

Ok, I see. Just a friendly reminder: For the issues to be usable it has to be more than a scratch pad for the main developers. This also goes for CVS commit messages that needs to be concise and informative to be easy to follow from "the outside".

anarcat’s picture

anarcat commented

Well, I think this was just a case of a typo in the topic of this issue, and the reason for that typo is that I filed the issue too quickly. For that I apologize.

However, I think I have tried maintain a pretty high standard of keeping relevant commitlogs and compartimented commits in decisions.

anarcat’s picture

anarcat commented
Assigned: Unassigned » anarcat
Status: Active » Fixed

Fixed in #45964.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)