Please review the patches. Those will add new functionality to the module including admin settings, if you like grant me access to CVS to commit (heshan.lk)

CommentFileSizeAuthor
inactive_user.module.patch20.92 KBhypertext200
inactive_user.install.patch1.19 KBhypertext200

Comments

MakeOnlineShop’s picture

MakeOnlineShop commented

Hi,

Do you know how many Emails send Inactive user module at each Cron ?

And is your patch made to modify it ?

I never managed to use a patch, can you propose a new version of the module already patched ?

Thanks a lot.

deekayen’s picture

deekayen commented
Status: Needs review » Needs work

Looks like this patch is not in a git-friendly format, it reverses some correct code styling, and leaves some code commented out for no apparent reason.

MakeOnlineShop’s picture

MakeOnlineShop commented

Hello,

Can you tell me if you have added this patch to the module ?

It is weird that nobody cares for a so important function ?

Thank you for your help.

deekayen’s picture

deekayen commented

No it has not. The patch doesn't follow Drupal coding standards, either for code style or for applying to a git repository. It also shouldn't abbreviate titles.