it'd be great to provide per-project RSS feeds of all new release nodes.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

or, 1 feed for all of their subscribed projects.

motshred’s picture

i cant read and i like it

purserj’s picture

This would be incredibly handy for those who are running Drupal hosting services. The ability to parse out the data and schedule module updates across a hundred sites or more would be very attractive.

aclight’s picture

Though this isn't quite the same thing, but #157514: Add possibility to retrieve a list of projects from the server is related to this.

aclight’s picture

Version: 4.7.x-1.x-dev » 5.x-1.x-dev
Status: Active » Postponed

#253611: Add feed for specific module releases was marked as a duplicate of this issue. I'd like to see this implemented in the D6 version of project*, which shouldn't be difficult considering that we'll require views and probably be using views to form the page that has a list of all project release nodes for a given project anyway. We can just add an additional RSS feed display to whatever view we use to create the page in the first place and we'll be in business.

Since this'll need to wait until the D6 port #157694: Upgrade project module to 6.x and views support #76726: Refactor project module to use Views [meta issue] I'm setting this to postponed for now.

pwolanin’s picture

Status: Postponed » Needs review
FileSize
3.59 KB

hmm, I wanted this also and just found this issue. Patch attached. It's pretty small... Did some basic testing.

aclight’s picture

FYI, this patch is only necessary for the D5 version. The in-the-works D6 version already has RSS feeds of project releases for a project implemented, with a select box for the Drupal version. I'd prefer that we not commit this patch and just wait until D6 is on d.o, to prevent any issues with URLs being different in the two different versions.

pwolanin’s picture

@aclight - it seems that Views2 allows you to specify any path for the RSS feed - I did think of the same concern. Or, if you know how the paths will look, I can re-roll to your spec. I guess it's a matter of timing and also whether there are other sites in the world using project* that would benefit.

aclight’s picture

As I've currently implemented it, the URL for a feed of all releases (unflitered) for a project is:
/node/110/release/feed

URLs with arguments for the API version look like this:
node/110/release/feed?api[0]=42

However, since none of this code has been committed to the d.o CVS, things could still change.

pwolanin’s picture

I think it's the same in the patch:

'node/'. $nid .'/release/feed/

No API version, but that can wait for D6

dww’s picture

I was just reminded of this issue and thought I'd give it a closer look. Yeah, it does seem that the RSS feeds have the same paths in both this patch and what aclight's view creates. I just refreshed the patch so it applies cleanly again, fixed up some translation bugs and minor formatting, and added a little special sauce via hook_nodeapi('rss item') so that we get the full table of release info in the feed items, and if there's a file, we include that as an enclosure attribute in the feed. Any objections?

dww’s picture

We should prepend the release info to both teasers and full text feed items.

dww’s picture

Even better, adds a feed icon after the "View all releases" link on the project nodes, e.g.:
http://project.drupal.org/project/views
Y'all can check out the feed over there now, too. ;)

advseb’s picture

This would be an important feature, please go for it!

aclight’s picture

Status: Needs review » Reviewed & tested by the community

I did a quick code review and don't see any problems. I don't really like how the feed icon looks next to the "View all releases" link on http://project.drupal.org/project/views, but I'm not quite sure why. To me, it looks like it is not properly aligned with the bottom of the link text. I magnified the screen (FF3 on the Mac), and indeed, there are some pixels that are close to white and part of the link text that extend one row of pixels lower than the bottom row of pixels of the feed icon. But I have a hard time believing that this is what I am noticing at normal size, because the pixels are so close to white and probably part of some anti-aliasing.

I guess I'm not sure that we need/want that feed icon there. The lists of issues are all feeds as well, but non of them have the feed icon.

I haven't tested the patch locally, but it looks like it's working on p.d.o. My concerns with the feed icon are pretty minor, and it's possible for other sites to get rid of the icon via the theme function, so I'll go ahead and RTBC this.

dww’s picture

Status: Reviewed & tested by the community » Fixed

- I agree the feed icon alignment isn't perfect, and I spent 5 minutes on it with FF and couldn't get it any better, so I'm going to punt for now. However, I think it's an important visual cue for this new feature -- otherwise I doubt anyone's going to find out since the "View all releases" page seems much less used.

- I also agree that the other links that point to feeds should have icons (eventually). That's why I put the theme function for this in project itself, not project_release. However, unlike this feed, the URLs for all those other feeds are all about to change, so I wanted to wait to add more feed icons until after the D6 port.

- Also, I asked Earl about this and Views2. Although some of this patch will be replaced by views, a lot of it is still valid. Views still uses nodeapi('rss item'), and the feed icon link on the project nodes will still be useful. So, this isn't really making any new work on top of the work you already put into this.

So, I committed to HEAD and DRUPAL-5, and deployed on d.o. Yay. ;)

dww’s picture

I also updated the What RSS feeds are available? handbook page.

hass’s picture

Nice feature. How about using a smaller icon? See http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/site_map/fe... where we've added a smaller one in past that fit better with the text size.

Example: View all releases

dww’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

the change to project_release_release_nodeapi() for the 'rss item' $op needs to be ported to HEAD.

dww’s picture

Status: Patch (to be ported) » Fixed

Never mind, it's there and working.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dww’s picture

Issue summary: View changes

onlyecig.com

Gábor Hojtsy’s picture

Issue summary: View changes

Copy of the revision from October 8, 2011 - 14:38.