Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The link mapper included in the feeds module has not yet been upgraded for Drupal 7. I've upgraded this mapper and have included a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 944986-6_link_mapper.patch | 9.9 KB | Anonymous (not verified) |
| #5 | 944986-5_link_mapper.patch | 5.49 KB | alex_b |
| #4 | fixed_link_mapper.patch | 5.42 KB | Anonymous (not verified) |
| #3 | fixed_link_mapper.patch | 5.42 KB | Anonymous (not verified) |
| link_mapper_upgrade.patch | 5.41 KB | Anonymous (not verified) | |
Comments
Comment #1
alex_b CreditAttribution: alex_b commented- Upgrade tests.
- Add Link module back into Feeds test profile.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedI've started work on the test fixes however, I noticed the use of the deprecated function
split()which I've replaced withpreg_split()instead.Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedI guess it would help if I attached the patch.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedIn anticipation of a future patch #953728: Upgrade text formats, use on all processors this adds a necessary fourth argument to
link_feeds_set_target()to my link mapper patch.Comment #5
alex_b CreditAttribution: alex_b commented- Cleaned up type check - no need to use $allowed_types when there is only one allowed type.
- Added //$Id$ line
- Added @file comment
Otherwise looking good.
Let's upgrade the tests before we commit that.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedI've added back in the link mapper test and upgraded it for Drupal 7 this patch should be good to go.
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedForgot to change the status to needs review.
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commented#7 has been committed http://drupal.org/cvs?commit=445022.
Comment #9
alex_b CreditAttribution: alex_b commentedGreat -
Can you get also rid of the reference to CCK - "... for Link CCK fields. Requires CCK and Link module": http://drupalcode.org/viewvc/drupal/contributions/modules/feeds/tests/fe...
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedI've made this changed and committed it here http://drupal.org/cvs?commit=445072.