Drupal 7 port

Same question, I use this module with D6 and love it and don't want to change. Not planning to move my site to D7 anytime soon but would like it for some other projects.

+1

subscribing

+1

I have created a port of the pathfilter module for D7. I haven't contributed to a modules development before so I am not sure if this should be a patch file or how I should go about contributing it. I am attaching as a zip file for now to this thread for people to try and will contribute as a patch a little later as well.

I have whipped up a patch that should provide an upgrade path from 6.x-1.0 to a 7.x-dev version.

Setting status to needs review to have patch reviewed

blischalk: You might need to regenerate the patch against the CVS or Git version of the module in order for the patch to apply cleanly. The main difference is that the CVS copy will have a different .info file because Drupal.org automatically generates some of those values. This will typically cause the patch process to fail since it won't find the lines that it is supposed to delete.

At this point, it probably makes more sense to work with the git copy (git clone git://git.drupalcode.org/project/pathfilter.git, probably). IIRC, the process is just to clone, do your changes, and then use `git diff` to generate the patch.

Given the upheaval in the Drupal version control world (Git migration happens this week), perhaps the maintainer would prefer to just manually merge the patch you already provided.

For a first shot at providing a patch, I'd say you've done an awesome job.

mbutcher: Thanks for the info! I will try re-rolling from the git version and re-attach.

Attaching a patch for a d7 port created from the .git version

I had to learn how to install git and learn the basics of how to use it in order to test this on my development site, but it seems to be working fine on my installation. I'll update if I find any problems.

subscribing

Subscribing. I'm looking to add an external: functionality and analytics onclick tracking to this module. Is this the right place to do it for D7 or should I start a brand new module if a D7 Path Filter branch is not going to be made?

subscribing, do want. Thanks.

I've created a new branch for D7 development. This is based of pathfilter 6.x-2.x. Please can you re-roll your patch against that.

Thanks.

I have re rolled the patch based on 6.x-2.x. I haven't had time to work on the tests but the files and internal paths appear to be working properly.

Setting status to needs review.

#16 didn't apply at all.

Ran through http://upgrade.boombatower.com and applied part of #16 and rewrote quite a bit more. This seems to work for internal:. Haven't tested files stuff.

Hey boomba, just our of curiosity, what directory where you doing git apply from? To apply the patch in #16 when I created it I had the patch in the pathfilter folder with the rest of the files and ran it from there. I just repeated the same steps again and didn't have any issues. Could this be why it didn't apply for you? What kind of errors did you run into when trying to apply?

6.x-2.x checkout from path filter directory, and same with 7.x-2.x. I then re-rolled mine from 7.x-2.x.

I rejected almost every hunk.

Since I am using i18n module to manage my multilingual site, I had issues linked with grabbing the node's language. I cannot really repatch the whole module, however, the fix for me lies in the "_pathfilter_process_internal" function. The conditions that were to work with i18n were not working. I changed the code in the function to this:

  if (module_exists('i18n')) {
    if ($path = drupal_get_normal_path($matches[3])) {
      if (substr($path, 0, 5) == 'node/') {
        $nid = substr($path, 5);
      }
    }
    elseif (preg_match('/(node\/([0-9]+))$/', $matches[3], $match)) {
      $nid = $match[2];
    }

    if (!empty($nid)) {
      $languages = language_list('enabled');
      $languages = $languages[1];                
      if (isset($languages)) {$url_array['language'] = $languages[i18n_node_get_lang($nid)];}
      $link = url('node/' . $nid, $url_array);
    }
  }

This also resulted in an error in i18n module since it uses "db_result" function which is no longer present in D7. I had to create a patch for that function as well. See #1144914: Node get language cannot use db_result() function for details.

It would be nice if someone could reroll a new dev version of this module otherwise it might become quite messy while reporting what and where does not work.

I've committed the initial port from #18. Thanks.

@ kunago - would you mind creating a new ticket for your issue so that we can track it easier?

@mrfelton - I created a new ticket: #1145450: Cooperation with i18n.

Here is a big patch.

This rewrite some parts of pathfilter totally, but now all previous features come to live.

Changes:
- global $_pathfilter_replacement_patterns; dropped
- added a new 'global settings' (pathfilter_menu() and pathfilter_global_settings())
- added new settings 'verbosity' to reporting pathfilter actions to the user (this is only global)
- pathfilter_process() splitted up to easily use the process from 'hook_node_prepare'
- the 'currying' function(s) dropped, we do not need it...
- now, for all filter settings we can select 'default' which means global setting used
- _pathfilter_internalize() rewrote to use only one regexp
- regexp creator functions dropped
- new hook functions added: pathfilter_node_prepare() and pathfilter_node_presave() to convert links back and forth for editing and saving
- if we add links with language path prefix, pathfilter reserves it, if not (and i18 activated) use the 'old' i18 code (this fix #21 issue http://drupal.org/node/945512#comment-4418348, http://drupal.org/node/1145450)

this patch @#24 should be run on which branch?

pathfilter 7.x-1.x-dev http://drupal.org/node/1107008

But i attach a newer 'full' tgz.

Please attache zip