Closed (fixed)
Project:
Homebox - Individual user dashboards
Version:
3.0.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Oct 2010 at 00:49 UTC
Updated:
29 Oct 2023 at 08:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
drummThis uses jQuery UI's sortable API, and currently doesn't have a fallback. I heard some work was done on accessible alternatives to drag & drop in Drupal 7, are there good examples or guidelines to follow?
Comment #2
Everett Zufelt commentedIn D7 I believe the Dashboard blocks are reorderable using the same style interface as reordering blocks for themes. This interaction model is a fallback for those users who cannot use the typical drag and drop interaction.
Note, this "bug" is with the redesign. As a result of this bug if it is necessary to open an issue with another module please open a separate issue. This bug should remain open against drupal.org redesign until required modules are patched and applied to drupal.org.
Comment #3
drummThis issue really belongs where the problem is, that is how we are managing every other issue.
It will take awhile, but we are closing out issues in Drupal.org Redesign, in favor of the the Webmasters, Infrastructure, and other issue queues linked at http://drupal.org/taxonomy/term/13. Tags are the best way to track these issues, http://drupal.org/project/issues/search?text=&projects=&assigned=&submit....
Comment #4
brianV commentedBumping version since 6.x-2.x is no longer being developed.
Comment #5
Everett Zufelt commentedMarking major as this is functionality that is completely missing, and not trivial, for more than one group of users.
Comment #6
brianV commentedFair enough. I am not sure of a good approach to handling this, though. How have jQuery draggable elements been made accessible in other sites / projects?
Comment #7
Everett Zufelt commentedYou can take a look at D7 tabledrag to get an idea of what we have done there. We might need to create our own solution for this.
Comment #8
StephenOTT commentedAny movement on this?
Is accessibility still an issue?
Comment #9
mgiffordIt still is an issue with the D6 version,
though I haven't tested to see if it's fixed with D7.With the home page on Drupal.org there are a couple accessibility issues that WAVE tossed up. I think the search boxes without labels will be fixed with the upgrade to D7.
However, the biggest issue with homebox I think is in not being able to access the controls to add, configure or delete the blocks without a mouse.
Since many sites will want to set up a dashboard for their users to access content that is relevant to them, this is a pretty big issue.
EDIT: Yes, this is still an issue with the D7 version.
Comment #10
mgiffordChanging versions as this is still an issue with the 7.x code.
Comment #11
mgiffordI haven't actually tested this, but it seems like this could work.
Add role="link" to the span that has the settings/navigation.
Insert some text so that AT knows what the link does. Then make that span invisible to the browser so that nobody else can see it.
Comment #12
BarisW commentedHi Mike,
I didn't test the patch, just looked at the code.
All new lines have double classes on each element.
Comment #13
yatil commentedIn addition, I’d question the
spanelements anyway. Semantically you click on thosespans and something happens. For me that is clearly abuttonelement.As an interactive element the
buttonis already in the tab order, and can be operated by screen reader users. No additionalroleortabindexattributes necessary.Comment #14
mgifford@BarisW - there's nothing wrong with more than one class span class="portlet-icon portlet-settings" that's also wasn't changed in the patch. Do let me know if I'm misunderstanding though.
@yatil - good point about the button and then not needing to worry about tabindex is good to know.
I'm attaching a patch with buttons, but it definitely needs js & css love.
Comment #15
BarisW commentedI meant the double class attributes, not the double classes. See the highlighted piece of code in #12
Comment #16
mgiffordRight.. I looked at that and then looked at it again and didn't see it. I think somehow class="element-invisible" got glued into my head as it's own entity. Thanks! Not sure how I missed that after you pointed that out.
Oh yes, a related issue from core #1719640: Use 'button' element instead of empty links
Comment #17
mgiffordWell, this is a bit closer, but I the hover/focus still isn't working properly, so it's hard to know when you're over the right button.
I just did some brief testing on /testbox and it is mostly working. Having this done right is going to be more important for mobile too. The action areas are just pretty small for anyone.
Ok I haven't changed this, but really don't think the portlet-header isn't using good semantics here. The header is a bunch of action links rather a description of the list of links that's coming next. it should much more be something like:
Comment #18
mgiffordChanging status. Although there are still problems with the existing patch. It's much more accessible than what's there right now.
Comment #19
mgiffordThat patch really doesn't work against the git repo. Seems everything has changed since I wrote this patch.
Comment #20
mgiffordI simplified it by not switching the links to buttons. They are no longer empty links though so this should help deal with keyboard accessibility. I've also added better i18n support.
Comment #21
mgiffordAlso against the git repo, but using buttons this time. The links with invisible text inside it didn't seem to work.
Comment #22
mgiffordtrying to address the styling added by the button change.
Comment #23
mgiffordI've added the background back to the buttons so that the images show up. I've also changed the order so that the tab order is logically.
Comment #24
mgiffordThis works, but the order of the buttons doesn't fit with the template.. No idea why. The JS must be reversing the output for some reason.
It also isn't working on SimplyTest.me any more. However, other than the ordering issue, it works now with the latest version of the code.
Comment #25
mgiffordButtons are in the wrong order, so I have to set this back to Needs work.
Comment #26
mgiffordComment #27
anybodyAs this stopped in 2014 I'd like to ask, if someone could perhaps create a separate issue and review the Drupal 8 / 9 version (2.x)?
Comment #28
anybodyThis may be picked up now with 3.x as it contains several fixes. With 2.0.x-alpha1 the module is kind of "usable" for the first time. Please help and contribute to make homebox "great again again......." ;D
Comment #29
anybodyDoesn't seem to be major, if it wasn't solved for 13Y ...
Comment #30
anybodyFixed in 3.0.x with the all new implementation. Using the element-invisible logic from above.