In field.inc mapper, in field_feeds_set_target it starts out like:

if (empty($value)) {
  return;

However, if $value is an integer `0` then empty(0) evaluates to empty and therefore returns instead of mapping the `0` value. Patch to follow.

CommentFileSizeAuthor
#6 949236-6_follow_up.patch2.17 KBIan Ward
#5 949236-5_follow_up.patch2.24 KBIan Ward
#4 949236-4_follow_up.patch2.1 KBalex_b
#2 feeds-mapper-zero-value-949236-2.patch730 bytesIan Ward
#1 feeds-mapper-zero-value-949236-1.patch901 bytesIan Ward
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ian Ward’s picture

Ian Ward CreditAttribution: Ian Ward commented
FileSize
feeds-mapper-zero-value-949236-1.patch901 bytes

I'm not sure this is the best way to handle. If rows are blank, PDO errors are thrown.

Ian Ward’s picture

Ian Ward CreditAttribution: Ian Ward commented
FileSize
feeds-mapper-zero-value-949236-2.patch730 bytes

Attached is a new patch based on our discussion.

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Title: typing issue when mapping values of "0" » Allow mapping empty values to fields
Status: Needs review » Fixed

This is committed, thank you http://drupal.org/cvs?commit=440162

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Status: Fixed » Needs review
FileSize
949236-4_follow_up.patch2.1 KB

Ok, we just shot ourselves in the foot: removing the empty check allows for mapping e. g. '' to a numeric which leads to PDO exceptions.

Ian Ward’s picture

Ian Ward CreditAttribution: Ian Ward commented
FileSize
949236-5_follow_up.patch2.24 KB

Attached is a re-roll with the 'list' type added to the numeric array. The 'list' field type accepts only numeric keys.

Ian Ward’s picture

Ian Ward CreditAttribution: Ian Ward commented
FileSize
949236-6_follow_up.patch2.17 KB

Another re-roll, which gets rid of notice when $callback is not set

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Status: Needs review » Fixed

Thanks, Ian.

http://drupal.org/cvs?commit=441514

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.