Bug is simple, when sorting a directory listing by "Display name", it's sorted by file FID instead.

CommentFileSizeAuthor
#2 filebrowser.diff2.3 KBopsidao

Comments

opsidao’s picture

opsidao commented

I added a print to each _filebrowser_sorter_* function in filebrowser.common.inc and I found that the _filebrowser_sorter_display_name callback is never called when sorting by "Display Name", while, for example, _filebrowser_sorter_description is called when sorting by that column.

opsidao’s picture

opsidao commented
StatusFileSize
new filebrowser.diff2.3 KB

I found it! In most place, we have "display-name", but we should have "display_name" so when constructing the name of the callback we get the correct one.

I attach a patch that seems to fix this.

Yoran’s picture

Yoran commented
Status: Active » Fixed

Thanks for this bug tracking !

In last dev, solution I use for this (and to handle metadatas) is to build sort function at runtime. Less duplicate code.

Status: Fixed » Closed (fixed)
Issue tags: -sorting

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +sorting

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.