"Unable to determine project type for drupal" when creating release

Erm.

Someone title-cased the "Drupal Project" taxonomy term (from Drupal project to Drupal Project), breaking the packaging script.

Moved all the terms back to their initial casing.

Drupal doesn't do title-casing *anywhere*, who decided that Drupal.org should do title-casing? *sigh*

Hi guys, that was me. I didn't realise things would break.

But yes, Drupal.org is supposed to be using title case according to our style guide. See the Headings (Capitalization) section on https://infrastructure.drupal.org/drupal.org-style-guide/editorial.html

(This also needs to move to Docs format and there's already an issue open)

@lisarex: things broke because they are not robust enough / not properly designed. So don't give you any hard time about that.

The point here (mine and Gabor's) is different, Drupal has been voluntary avoiding title-casing for years, it seems very weird to get back to it now, without a strong reason.

@damien, thanks :)

There isn't widespread knowledge that we're supposed to use title case, at least on main headings.

I am getting this error again.

Seems it was fixed in drush make: #950018: Unable to determine project type for drupal, and I am not getting it on local either when using my full makefile which has project[] = drupal in it, could it be that the drush make needs updating on d.o?

Possibly related: #1105820: converted install profile doesn't pass validation

This was fixed in drush_make 6.x-2.1, so that version or later would be good.

no, it would probably be really bad to update to that version... ;)

for some reason, nobody updated drush_make on drupal.org in the git migration, at least as far as i can tell. it's still a CVS checkout of DRUPAL-6--2-0-BETA5. there have been major changes on the 2.x branch since then, and updating will almost assuredly break things even worse than they are now.

i can't fix this alone, we need to bring in somebody who's more familiar with the current state of drush_make, specifically the drush_make drupalorg plugin that drives the distro packaging.

I believe that #1105820: converted install profile doesn't pass validation was a duplicate of this issue.

I fail to see what big breakage would occur by upgrading from a 2.0-beta to 2.x, can you clarify? Do you mean specifically 2.1 or would an upgrade to 2.2 fix this?

My opinion is that we should follow drush make's 2.x branch. Right now, things are just completely broken for distros, I fail to see how it could possibly be worse. 2.2 works well right now...

Subscribe

I've manually applied the patch from http://drupal.org/node/950018#comment-4161076 to the version that d.o runs.

Before that I had udated to 6.x-2.2 but that broke things even more snce the "verify makefile" isn't contained in that release.

Didn't help. It seems as if this may not have been updated to git.

I can verify at least that this was never really tested before the Git migration went live, unfortunately. To this day I don't really understand that well how the system is put together, so I'm not sure exactly where the problem is. I assume it's probably in the makefile-handling plugin in drupalorg module, but I don't quite know.

My opinion is that we should follow drush make's 2.x branch. Right now, things are just completely broken for distros, I fail to see how it could possibly be worse. 2.2 works well right now...

i'm guessing you're using drush_make locally to say that. drupal.org uses a drush plugin for it's makefile handling, and that was broken horribly in post 2.x beta releases -- i have no idea if it was ever properly fixed, or if it was updated to deal with the git migration. this is why i'm requesting some input/assistance from the drush_make maintainers.

Yes, we are using drush_make locally, extensively.

I am not aware of how drupal.org uses drush make or drush, but if this is documented or if I am given access, I could help.

This is a critical issue for us people that are trying to bring distributions back on Drupal.org, and I would be willing to spend some time to fix this. I am one of the Drush maintainers and I have contributed multiple patches to drush_make also, so I know my way around.

@killes - regarding the "verify makefile" task missing - how about we just ditch that? Effectively, creating a release *will* verify the makefile, and if we use the "standard" drush_make, then people can verify the makefile all by themselves, offline, without asking drupal.org.

I think we should focus on a small, simple fix, even if this means reduced functionality.

Okay, point taken. Let's see here...

In 2.2, verify is still there, it was just renamed:

anarcat@marcos:.drush$ wget http://ftp.drupal.org/files/projects/drush_make-6.x-2.2.tar.gz
anarcat@marcos:.drush$ tar zxf drush_make-6.x-2.2.tar.gz
anarcat@marcos:.drush$ drush help | grep verify
 convert-makefile      Convert the specified makefile to a drupal.org friendly format, and verify the converted file.
 verify-makefile       Verify the specified makefile is in a drupal.org-friendly format.

It just complied with Drush4 requirements that commands do not have spaces in them.

Can we try again? :)

Also note that if you're going to fiddle around drupal.org code like this, you might as well try this RTBC patch which would fix this issue for some of us: #751242: Install profiles cannot create releases with a non drupal-org makefile.

Thanks for looking into this, Gerhard!

So, the idea is to use the 2.2 version of drush_make and change the call from "verify makefile" to "verify-makefile"? I'd try that if I knew where the all was located...

That is correct. I would also love to help, but I have also no idea where it is... Maybe in the frontend code, a .module somewhere in the drupal.org site?

got it, it's in project_verify_package.pages.inc in /var/www/drupal.org/htdocs/sites/all/modules/drupalorg/project_verify_package
I'll try that later. But I am afraid that it may not work due to the git migration

We are successfully using drush_make to download packages from drupal.org through git right now, it works fine. :)

Thanks for looking into this again!

I just had success with a Drupal 7.2 Install Profile dev release using:

core = 7.2

; Themes
projects[mayo] = "1.1"

; default modules
projects[backup_migrate][subdir] = "contrib"
projects[backup_migrate][version] = "2.1"

projects[advanced_help][subdir] = "contrib"
projects[advanced_help][version] = "1.0-beta1"

This is progress since it wouldn't work for weeks. I don't know the actual packaging schedule so can't verify if the packaging will be done.

Thanks to somebody for sure.

Sorry I haven't been able to deal with this yet. Mea culpa -- this was one of the Git migration messes I should have cleaned up and I didn't. Glad to see progress being made here. I'll circle back on Monday and try to help clear up any remaining questions/confusion/problems. I don't have energy now, and I won't have time before then to focus on this. But, this issue is now near the top of my Drupal-related TODO list for Monday.

Thanks,
-Derek

The .make file was accepted as in #32 above, but when the packaging roles around it gives this error:

Packaging error messages

  ERROR: Can't find core release for DRUPAL-7-2

Just spent a few hours testing, fixing, and deploying all the bugs in here. Distro packaging is (mostly) now working again on d.o.

However, there's one feature we lost, which we should attempt to fix ASAP:

#1178942: distribution packaging plugin doesn't record package contents

But, the critical packaging bug here is now fixed, and folks should be able to make distro releases again.

Sorry, for completeness, here's exactly what I did:

• Upgraded drush in /var/www/drupal.org/tools/drush to 7.x-4.4 (just using a pure Git checkout for now)
• Upgraded drush_make in /var/www/drupal.org/tools/drush_make to 6.x-2.2 (just using a pure Git checkout for now)
• Ported project_verify_package to use drush_make 6.x-2.2 commands: http://drupal.org/commitlog/commit/4364/6a27db0db497dd41f4542d76065eaa64...
• Fixed the bug mentioned in #35 above, which was unfinished business from #781246: Write Git-specific packaging plugin for d.o: http://drupal.org/commitlog/commit/4364/17dc699ca09f12c35e885d36fd25d474...
• Actually committed and deployed hunmonk's patch at #751242: Install profiles cannot create releases with a non drupal-org makefile: http://drupal.org/commitlog/commit/4364/6751c3a8fa49845ef91fd0d71f7855b1...
• Discovered #1178942: distribution packaging plugin doesn't record package contents, debugged, committed, and deployed the fix.

Any further problems with distro packaging should just go into new issues.

Thanks and sorry all this was broken for so long. Life hasn't been particularly kind to me recently, so I haven't had the bandwidth to deal with stuff like this that I normally do...

Not sure if this is related, but I can't seem to get my install profile packaged ... and trying to verify a one-liner makefile still throws errors (but now a different one):

The command 'drush.php verify-makefile -' could not be found

Attached screenshot:

Thank you so much! I was able to make a release of the install profile this time. I did get janusman's error when attempting to verify my makefile, but it didn't seem to affect the release of the install profile. Perhaps it should be a separate issue? At the least it no longer seems critical as long as it's possible to make releases.

@Gabor: That bug is over at #1098536: Releases block broken on project pages - doesn't show newly published security release -- thanks for the reminder that it's still broken. ;)

@janusman and @dnotes: Yeah, let's move that to a new issue. This one is fixed and already getting a bit too unwieldy. Let's deal with the verify bug over at #1181554: Validation errors when verifying drupal-org.make files for distribution packaging

Thanks,
-Derek