Warning on PHP 5.3: date_form_alter() expected to be a reference, value given

I'm not sure I completely understand what's going on here. I realize that drupal_alter() does allow passing arguments by reference where needed, but afaict it isn't necessary here.

Here is the call stack:

1. function date_form_alter(&$form, &$form_state, $form_id)
2. function date_content_display_form(&$form, &$form_state)
3. function date_formatter_settings($form_state = NULL, $field, $options = array(), $views_form = FALSE)
4. function _date_formatter_settings($form_state = NULL, $field, $options = array(), $views_form = FALSE)

So, $form_state is passed by reference to date_form_alter() which passes it by reference to date_content_display_form(). From here it gets passed by value to date_formatter_settings() and then _date_formatter_settings(). The first three functions seem to do nothing with this value except to pass it to the next function in the list, and _date_formatter_settings() doesn't even use this value.

Either $form_state is there for possible future use, or it's being used in some clever way I'm not immediately seeing because I am not wise in the ways of the Drupal form API. Assuming the first case this patch should be safe, but at minimum I think that for consistency it should also change date_content_display() to not call $form_state by reference either.

revised patch which changes date_content_display() as described above

thanks a lot for the patch.
i had this error and it was very annoying.

same here - patch working.
However, the problem seems to be elsewhere because passing $form_state as reference deliveres correct function signature according to FormsAPI.

As I get this warnings on a whole bunch of modules that implement hook_form_alter() there seems to be something wrong in drupal core. I will try 6.20 later (currently using 6.19).

edit: updating core to 6.20 doesn't help

Same here. The issue is probably not related to Date (not sure). I get a whole bunch of the warnings whenever I try to attach a file to a node - including warnings related to Date. See attached screenshot. BTW: using Drupal 6.20

Updated patch for 6.x-2.7

Having the same issue.

PHP 5.3.3
Drupal 6.20

Is the patch in #8 going to show up in a stable release anytime soon?

@chey your help is needed with that -- first the patch needs to be reviewed! please try the patch, and whether it works for you or not, report your experiences here. when it's been tested and shown to work, the maintainer will know it's okay to add.

see http://drupal.org/patch/review if you've never done this before.

The patch doesn't apply to 2.7, I think because the paths are wrong like in

--- a/sites/all/modules/patched/date/date/date.module
+++ b/sites/all/modules/patched/date/date/date.module

The 'patched' part shouldn't be there I guess. Corrected version attached. Applies and makes errors disappear.

Marking as duplicate:

#747680: PHP 5.3 warning on date_form_alter()
#1078450: PHP 5.3 issue with date_timezone_form_alter function
#1078446: PHP 5.3 issue with date_form_alter function

This is a problem with many modules; see also http://drupal.org/node/710892 .

The patch in #11 worked well for me.

Patch in #11 worked for me. I no longer get the two date related errors when uploading a file. Running D6.21 with PHP 5.32.

setting to RTBC based on multiple positive reviews

Are you sure this isn't related to #925580: Upload throws warnings on PHP 5.3?

I think this was fixed here:
#925580: Upload throws warnings on PHP 5.3