Download & Extend
Feeds » Issues

Remove BOM from UTF-8 files

Posted by yhahn on October 26, 2010 at 5:54pm
Project:Feeds
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

As we discovered recently UTF-8 files containing the BOM do not have the character stripped by PHP when read from the filesystem or included in code. This affects certain import files used by Feeds, in particular the column names of csv files can become mangled.

Patch forthcoming which removes the BOM character as part of the Fetcher step.

Login or register to post comments

Comments

#1

Posted by yhahn on October 26, 2010 at 5:54pm
AttachmentSizeStatusTest resultOperations
953538.1.patch3.6 KBIgnored: Check issue status.NoneNone

#2

Posted by yhahn on October 26, 2010 at 6:44pm

V2 of patch, keeps changes contained to Fetcher classes by using sanitizeRaw() and sanitizeFile() methods.

AttachmentSizeStatusTest resultOperations
953538.2.patch3.76 KBIgnored: Check issue status.NoneNone

#3

Posted by alex_b on October 26, 2010 at 6:46pm
Status:needs review» reviewed & tested by the community

Rock!

#4

Posted by yhahn on October 26, 2010 at 7:07pm
Status:reviewed & tested by the community» fixed

http://drupal.org/cvs?commit=441930

#5

Posted by System Message on November 9, 2010 at 7:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.