The configure button shows to users who do not have the permission 'administer administration dashboard'. If an unprivileged user follows the link, they still received the access denied. This can confuse users by making them think they can do something and then are not allowed.

CommentFileSizeAuthor
#2 admin_dashboard-954926-2-configure-button-access.patch2.67 KBrecrit
#1 admin_dashboard-954926-configure-button-access.patch1.33 KBrecrit

Comments

recrit’s picture

recrit commented
Status: Active » Needs review
StatusFileSize
new admin_dashboard-954926-configure-button-access.patch1.33 KB

the attached patch adds a check for the permission 'administer administration dashboard'. If a user has access then the additional configure button is added the javascript settings.

recrit’s picture

recrit commented
Title: Configure button shows to users with no access » Settings buttons show to users with no access
StatusFileSize
new admin_dashboard-954926-2-configure-button-access.patch2.67 KB

Changing title to more suitable for all setting buttons
updates to patch:

  • removed setting buttons with non existent variable 'admin_dashboard_setting_buttons', if add setting in the future, can add back
  • added check for NOT anonymous for "auto hide" button so it does not show to anonymous (if perms allow)
skilip’s picture

skilip commented
Status: Needs review » Patch (to be ported)

Looks good to go. Thanks a bunch!